Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Dec 30, 2022

Related command

Description

[AKS] az aks create/update: Add support for KEDA workload auto-scaler

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

Vighnesh Shenoy and others added 6 commits December 30, 2022 07:26
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
@ghost ghost requested review from yanzhudd and zhoxing-ms December 30, 2022 07:30
@ghost ghost assigned zhoxing-ms Dec 30, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 30, 2022
@ghost ghost requested a review from yonzhan December 30, 2022 07:30
@ghost ghost added the AKS az aks/acs/openshift label Dec 30, 2022
@FumingZhang
Copy link
Member Author

Live test failed due to some error on rp side.

@yonzhan yonzhan added this to the Dec 2022 (2023-01-10) milestone Dec 30, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 30, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review January 3, 2023 02:03
Copy link

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We also need to add some test yamls, right?

@zhoxing-ms
Copy link
Contributor

@v-shenoy In fact, it is not necessary to add yaml files for the @live_only tests.

@zhoxing-ms zhoxing-ms merged commit faccf0b into Azure:dev Jan 3, 2023
@FumingZhang FumingZhang deleted the fuming/keda-addon branch February 17, 2023 02:18
avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants