[AKS] az aks create/update: Add support for KEDA workload auto-scaler
#24698
Conversation
ghost
requested review from
ghost
assigned
|
AKS |
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy <[email protected]>
|
Sync changes from PR #4905 in aks-preview. |
|
|
||
| return mc | ||
|
|
||
| def update_workload_auto_scaler_profile(self, mc: ManagedCluster) -> ManagedCluster: |
There was a problem hiding this comment.
You should move this function to the other class AKSManagedClusterUpdateDecorator. The function to construct the updated profile (update_mc_profile_default) is also in this class.
|
|
||
| # create: enable-keda | ||
| create_cmd = 'aks create --resource-group={resource_group} --name={name} --location={location} --ssh-key-value={ssh_key_value} --output=json ' \ | ||
| '--aks-custom-headers=AKSHTTPCustomFeatures=Microsoft.ContainerService/AKS-KedaPreview ' \ |
There was a problem hiding this comment.
Does this feature still need the feature flag? If not, please remove this custom header
There was a problem hiding this comment.
Currently, it does. Once all other changes are done for GA, we will remove the feature flag. I'll send in another PR to change that here as well.
|
|
||
| # update: enable-keda | ||
| update_cmd = 'aks update --resource-group={resource_group} --name={name} --yes --output=json ' \ | ||
| '--aks-custom-headers=AKSHTTPCustomFeatures=Microsoft.ContainerService/AKS-KedaPreview ' \ |
There was a problem hiding this comment.
Also remove this header if the feature is not protected by AFEC anymore.
There was a problem hiding this comment.
Please refer to my reply above.
|
PR blocked by SDK for containerservice generated according to latest stable API 2022-11-01 not released yet. |
|
Closing as another PR (#25007) has been raised for the same. |
4 participants
Related command
Description
Allows AKS customers to enable / disable the KEDA addon for workload autoscaling.
Testing Guide
History Notes
[AKS]
az aks create: Add new parameter--enable-kedato enable KEDA workload auto-scaler[AKS]
az aks update: Add new parameters--enable-keda/--disable-kedato enable/disable KEDA workload auto-scalerThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.