Skip to content

Conversation

@major
Copy link
Contributor

@major major commented Nov 4, 2021

Description
The latest version of knack is 0.8.3 and it was just released.

Testing Guide
Existing tests should be used.


This checklist is used to make sure that common guidelines for a pull request are followed.

The latest version of knack is 0.8.3 and it was just released.

Signed-off-by: Major Hayden <[email protected]>
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 4, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Thank you for your contribution major! We will review the pull request and get back to you soon.

@jiasli
Copy link
Member

jiasli commented Nov 4, 2021

Thanks @major. The latest knack introduced breaking change about colorama (microsoft/knack#249).

The corresponding Azure CLI adaptation will be covered by #20195.

@jiasli
Copy link
Member

jiasli commented Nov 4, 2021

By the way, just out of curiosity, how did you notice there is a new knack release? 😆

@major
Copy link
Contributor Author

major commented Nov 4, 2021

@jiasli Oh, I have knack packaged in Fedora. When a new release appears on GitHub, Anitya opens a bugzilla ticket for me to package the update. It's usually pretty fast at finding new releases.

@major
Copy link
Contributor Author

major commented Nov 4, 2021

I guess I'll close this ticket since the work is happening in #20195

@major major closed this Nov 4, 2021
@major major deleted the update-knack branch November 4, 2021 13:02
@jiasli
Copy link
Member

jiasli commented Nov 4, 2021

Interesting. Just a kind reminder that Knack is not stable yet since the major version is still 0, we don't guarantee its backward compatibility (just like the colorama dependency change (microsoft/knack#249) - libraries depending on knack shouldn't assume colorama will always be installed).

@major
Copy link
Contributor Author

major commented Nov 4, 2021

Interesting. Just a kind reminder that Knack is not stable yet since the major version is still 0, we don't guarantee its backward compatibility (just like the colorama dependency change (microsoft/knack#249) - libraries depending on knack shouldn't assume colorama will always be installed).

Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants