-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Packaging] Support Python 3.10 #20195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Packaging |
| six==1.14.0 | ||
| sshtunnel==0.1.5 | ||
| tabulate==0.8.3 | ||
| tabulate==0.8.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old tabulate uses string to compare version, resulting in "10" < "3", which is certainly wrong.
if python_version_tuple() >= ("3", "3", "0"):
from collections.abc import Iterable
else:
> from collections import Iterable
E ImportError: cannot import name 'Iterable' from 'collections' (/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/collections/__init__.py)
env/lib/python3.10/site-packages/tabulate.py:16: ImportError
This is fixed by astanin/python-tabulate#105.
wangzelin007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| if enable_color: | ||
| message = Style.BRIGHT + message + Style.RESET_ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We remove the color here as it outshines whole original help messages and examples.
| 'azure-synapse-managedprivateendpoints~=0.3.0', | ||
| 'azure-synapse-spark~=0.2.0', | ||
| 'chardet~=3.0.4', | ||
| 'colorama~=0.4.4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colorama was removed from Knack for non-Windows systems (microsoft/knack#249), but azure-cli still needs it.
|
Still seeing |
|
Installing |
Description
Close #19857
Python 3.10 has been released on 2021-10-04: https://www.python.org/downloads/
Azure CLI needs to support Python 3.10 like how we supported 3.9.
References