Skip to content

{Compute} Fix mock logic for test_read_images_from_alias_doc #19843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 1 commit into from
Dec 8, 2021
Merged

{Compute} Fix mock logic for test_read_images_from_alias_doc #19843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 0 additions & 84 deletions src/azure-cli/azure/cli/command_modules/vm/tests/hybrid_2018_03_01/aliases.json
View file
Open in desktop

This file was deleted.

12 changes: 2 additions & 10 deletions src/azure-cli/azure/cli/command_modules/vm/tests/hybrid_2018_03_01/test_vm_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,10 @@ def _get_test_cmd():


class TestVMImage(unittest.TestCase):
@mock.patch('azure.cli.command_modules.vm.custom.urlopen', autospec=True)
def test_read_images_from_alias_doc(self, mock_urlopen):

def test_read_images_from_alias_doc(self):
from azure.cli.command_modules.vm.custom import list_vm_images
cmd = _get_test_cmd()
file_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
'aliases.json')
with open(file_path, 'r') as test_file:
test_data = test_file.read().encode()

mock_read = mock.MagicMock()
mock_read.read.return_value = test_data
mock_urlopen.return_value = mock_read

# action
images = list_vm_images(cmd)
Expand Down
84 changes: 0 additions & 84 deletions src/azure-cli/azure/cli/command_modules/vm/tests/hybrid_2019_03_01/aliases.json
View file
Open in desktop

This file was deleted.

12 changes: 2 additions & 10 deletions src/azure-cli/azure/cli/command_modules/vm/tests/hybrid_2019_03_01/test_vm_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,10 @@ def _get_test_cmd():


class TestVMImage(unittest.TestCase):
@mock.patch('azure.cli.command_modules.vm.custom.urlopen', autospec=True)
def test_read_images_from_alias_doc(self, mock_urlopen):

def test_read_images_from_alias_doc(self):
from azure.cli.command_modules.vm.custom import list_vm_images
cmd = _get_test_cmd()
file_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
'aliases.json')
with open(file_path, 'r') as test_file:
test_data = test_file.read().encode()

mock_read = mock.MagicMock()
mock_read.read.return_value = test_data
mock_urlopen.return_value = mock_read

# action
images = list_vm_images(cmd)
Expand Down
84 changes: 0 additions & 84 deletions src/azure-cli/azure/cli/command_modules/vm/tests/hybrid_2020_09_01/aliases.json
View file
Open in desktop

This file was deleted.

12 changes: 2 additions & 10 deletions src/azure-cli/azure/cli/command_modules/vm/tests/hybrid_2020_09_01/test_vm_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,10 @@ def _get_test_cmd():


class TestVMImage(unittest.TestCase):
@mock.patch('azure.cli.command_modules.vm.custom.urlopen', autospec=True)
def test_read_images_from_alias_doc(self, mock_urlopen):

def test_read_images_from_alias_doc(self):
from azure.cli.command_modules.vm.custom import list_vm_images
cmd = _get_test_cmd()
file_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),
'aliases.json')
with open(file_path, 'r') as test_file:
test_data = test_file.read().encode()

mock_read = mock.MagicMock()
mock_read.read.return_value = test_data
mock_urlopen.return_value = mock_read

# action
images = list_vm_images(cmd)
Expand Down
Loading