{Compute} Fix mock logic for test_read_images_from_alias_doc

[zhoxing-ms]

Description

Because in the previous PR #5328, the reference of urlopen in the method load_images_from_aliases_doc() was modified to use requests, but the mock path in test_read_images_from_alias_doc() was not synchronously modified.

code link

So we need to change the mock path azure.cli.command_modules.vm.custom.urlopen to azure.cli.command_modules.vm.custom.requests

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[jiasli]

Please remember to rename the parameter mock_urlopen accordingly.

[jiasli]

I haven't looked into it in detail, but response will be a MagicMock. Will the mock work? Or why did it work before with the wrong mock?

[zhoxing-ms]

I haven't looked into it in detail, but response will be a MagicMock. Will the mock work? Or why did it work before with the wrong mock?

Good question!

Previously, the purpose of this mock was to mock the querying results of https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/quickstart-templates/aliases.json when the method all_images = load_images_from_aliases_doc(cmd.cli_ctx, publisher_name, offer, sku) was called.
I speculate that this is to prevent the test from blocking when the remote file cannot be accessed, so the local cache file aliases.json is used to mock the access results of the remote file.

However, since there was a new PR #10852 to add the logic of reading local json dict when remote files cannot be accessed to the method load_images_from_aliases_doc()

    except requests.exceptions.ConnectionError:
        logger.warning("Failed to retrieve image alias doc '%s'. Error: 'ConnectionError'. Use local copy instead.",
                       target_url)
        dic = json.loads(alias_json)

code link

Since the logic of querying alias_json for fault tolerant in method load_images_from_aliases_doc() has replaced the function of mock logic, so even if the mock logic is wrong, they will not affect the process of load_images_from_aliases_doc. Therefore, these mock logics can be deleted directly.