{Core} Drop azure-common from azure-cli-core
#19551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
evelyn-ys,
jsntcy,
kairu-ms and
zhoxing-ms
as code owners
Collaborator
|
Core |
zhoxing-ms
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
azure-commonwas introduced when vendoringazure-mgmt-resourceTrack 2 SDK (#15711). It should have been dropped by #18047 but was unintentionally overlooked.azure-commonis an interface to create SDK clients with Azure CLI credential. Azure CLI doesn't use it in any way.azure-commonhas now been deprecated.Leaving it in
azure-cli-corecauses confusion and encourages incorrect usages: #19528