{Core} Stop using vendored azure-mgmt-resource SDK
#18047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft,
houk-ms and
jsntcy
as code owners
Collaborator
|
Core |
zhoxing-ms
reviewed
May 13, 2021
| _AZ_LOGIN_MESSAGE = "Please run 'az login' to setup account." | ||
|
|
||
| _USE_VENDORED_SUBSCRIPTION_SDK = True | ||
| _USE_VENDORED_SUBSCRIPTION_SDK = False |
Contributor
There was a problem hiding this comment.
Since the vendor SDK has been deleted, why do we still keep the logic of this switch?
Member
Author
There was a problem hiding this comment.
In case there is a track 3 someday. 😏
zhoxing-ms
approved these changes
May 13, 2021
evelyn-ys
approved these changes
May 24, 2021
jiasli
changed the title
azure-mgmt-resource SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop using vendored subscription SDK in core as
azure-mgmt-resourcehas been migrated to Track 2 (#17783).