-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[ARM] Fix #19468: pip installs azure-cli 2.0.73 because of the dependency on deprecated jsmin
#19495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
use_2to3 is invalid introduced by jsminuse_2to3 is invalid introduced by jsmin
|
ARM |
...ure/cli/command_modules/resource/tests/latest/recordings/test_resource_group_deployment.yaml
Outdated
Show resolved
Hide resolved
8860cc5 to
fbe4a3f
Compare
|
Please include the the license of Lines 2663 to 2686 in c145c29
|
fbe4a3f to
4d02a75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can disable all checks for the whole file with
# pylint: skip-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to put JSON related functions in this file in the future, so I just disable the pylint of this function for the time being
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put the origin of the code here: https://github.com/tikitu/jsmin/blob/release-2.2.2/jsmin/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
use_2to3 is invalid introduced by jsminpip installs azure-cli 2.0.73 because of the dependency on deprecated jsmin
229ada4 to
c6da326
Compare
|
Kind reminder: tikitu/jsmin#34 has been merged and jsmin 3.0.0 has been released. |
Issue: #19468
Description
In order to solve the package conflict introduced by
jsmin, thejsmincode is referenced intojson_min()Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.