{Upgrade} Retrieve latest version from main branch
#19191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
Juliehzl,
evelyn-ys,
jsntcy and
kairu-ms
as code owners
Member
Author
|
This problem is currently mitigated by manually fast-forwarding |
Collaborator
|
Upgrade |
jsntcy
approved these changes
Aug 11, 2021
jiasli
commented
Aug 11, 2021
| def get_latest_from_github(package_path='azure-cli'): | ||
| try: | ||
| import requests | ||
| git_url = "https://raw.githubusercontent.com/Azure/azure-cli/master/src/{}/setup.py".format(package_path) |
Member
Author
There was a problem hiding this comment.
As old Azure CLI versions installed on customer's machines have master hardcode in source code, we can never deprecate master branch, otherwise all old versions of Azure CLI can't use az upgrade to upgrade to the latest version anymore - a deadlock!
The only possible solution is to manually upgrade Azure CLI.
yonzhan
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the renaming of
mastertomain,masterbranch is no longer maintained.az upgradeshould fetch the version frommainbranch instead.