Skip to content

Conversation

@calvinsID
Copy link
Contributor

Description
Let users get github personal access token interactively using #17826

Testing Guide
az staticwebapp create --login-with-github
az staticwebapp reconnect --login-with-github


This checklist is used to make sure that common guidelines for a pull request are followed.

@panchagnula
Copy link
Contributor

@calvinsID don't see any tests added here or updated -do we not have any existing ones or at least add one?

@yungezz yungezz added the App Services az appservice label May 14, 2021
@calvinsID
Copy link
Contributor Author

calvinsID commented May 17, 2021

@calvinsID don't see any tests added here or updated -do we not have any existing ones or at least add one?

Good call, updating

@calvinsID calvinsID added this to the S187 milestone May 17, 2021
@calvinsID calvinsID force-pushed the user/calcha/staticwebapp-get-access-token branch from 146c991 to 09c2a35 Compare May 17, 2021 14:54
@panchagnula
Copy link
Contributor

@calvinsID don't see any tests added here or updated -do we not have any existing ones or at least add one?

I'm not too sure how to add tests since the functionality requires the user to navigate to github website to enter the code

Hmm I see - Elle had added some Mock test when she originally did the commands . May be just re-run this to make sure they still work?

@calvinsID
Copy link
Contributor Author

@calvinsID don't see any tests added here or updated -do we not have any existing ones or at least add one?

I'm not too sure how to add tests since the functionality requires the user to navigate to github website to enter the code

Hmm I see - Elle had added some Mock test when she originally did the commands . May be just re-run this to make sure they still work?

Yup good call, thanks! Updated

@qwordy
Copy link
Member

qwordy commented May 19, 2021

@panchagnula Is it OK to merge?

@calvinsID
Copy link
Contributor Author

@qwordy added logging message if both token and --login-with-github are provided, thanks!

@qwordy
Copy link
Member

qwordy commented May 21, 2021

Code owner review required

@Juliehzl Juliehzl merged commit 22d974a into Azure:dev May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App Services az appservice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants