-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[AppService] Add interactive way to get token for staticwebapp #18083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppService] Add interactive way to get token for staticwebapp #18083
Conversation
|
@calvinsID don't see any tests added here or updated -do we not have any existing ones or at least add one? |
Good call, updating |
146c991 to
09c2a35
Compare
Hmm I see - Elle had added some Mock test when she originally did the commands . May be just re-run this to make sure they still work? |
Yup good call, thanks! Updated |
|
@panchagnula Is it OK to merge? |
|
@qwordy added logging message if both |
|
Code owner review required |
Description
Let users get github personal access token interactively using #17826
Testing Guide
az staticwebapp create --login-with-githubaz staticwebapp reconnect --login-with-githubThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.