[AppService] az appservice: Add function to retrieve users github personal access token #17826

calvinsID · 2021-04-22T19:01:50Z

Description

Add function get_github_access_token to help users retrieve github access token easier
Following doc: https://docs.github.com/en/developers/apps/authorizing-oauth-apps#device-flow

Testing Guide
This is not exposed in a command yet, as I'm not sure what command to put it under. We will be using this function in webapp commands in the future, and static webapps have use cases as well

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

qwordy · 2021-04-23T02:46:08Z

src/azure-cli/azure/cli/command_modules/appservice/_constants.py

Could you share where this ID comes from?

It's an oauth app created by AppService CLI team: https://github.com/AzureAppServiceCLI
Is there an official Azure oauth app we can use, or should we stick to this one?

panchagnula

Can't wait for supporting GitHub actions on CLI with full GitHub authentication with this. Thank you.

qwordy · 2021-04-26T04:32:41Z

"Azure.azure-cli (Check CLI Style)" has problems. We are fixing it. New version of astroid changed __version__ to version.

calvinsID · 2021-04-26T19:03:27Z

Hi @qwordy do you mind re-reviewing the latest commit? I added additional changes to support az webapp deployment github-actions command in the webapp extensions repo: Azure/azure-cli-extensions#3303

panchagnula · 2021-04-27T21:18:25Z

Azure/azure-cli-extensions#3303

@calvinsID can you update the title to include the support for GitHub actions as well since this will be used automatically to update the release history documentation to the users?

qwordy · 2021-04-29T02:33:15Z

src/azure-cli/requirements.py3.windows.txt

Also add it to setup.py otherwise pip install will fail

Added. Why are only some of the requirements.txt added to setup.py dependencies?

pip install reads setup.py. Windows MSI artifact build reads requirements.txt. It makes me confused why two dependency definitions, too.
@fengzhou-msft Could you answer the question by Calvin?

panchagnula · 2021-05-03T15:09:27Z

@calvinsID looks like this change has some merge conflicts.

…LI extensions repo) and github_action property in az webapp deployment source config command

calvinsID · 2021-05-03T18:01:26Z

@qwordy wondering if u know how I can fix the failing check?

qwordy · 2021-05-07T05:08:32Z

@qwordy wondering if u know how I can fix the failing check?

Just rerun

jiasli · 2021-06-21T07:07:03Z

src/azure-cli/setup.py

    'jsmin~=2.2.2',
    'jsondiff==1.2.0',
    'packaging~=20.9',
+    'PyGithub==1.38',


github module is not imported anywhere. Is this dependency necessary?

The pinned version causes problem when being installed with the latest PyGithub (#18548):

azure-cli 2.24.2 requires PyGithub==1.38, but you'll have pygithub 1.55 which is incompatible.

I should have added it to this PR instead, it will be used in this one #18261. And yes we shouldn't pin, we can use ~= and unpin. Thanks for bringing this up

Could you change the dependency to use ~= instead?

calvinsID requested a review from panchagnula April 22, 2021 19:01

calvinsID requested review from Juliehzl and qwordy as code owners April 22, 2021 19:01

calvinsID force-pushed the github-access-token branch from ace0a06 to 788d2d0 Compare April 22, 2021 19:04

calvinsID changed the title ~~Add function to retrieve users github personal access token~~ [AppService] Add function to retrieve users github personal access token Apr 22, 2021

calvinsID added this to the S186 milestone Apr 22, 2021

yungezz assigned qwordy Apr 23, 2021

yungezz added the App Services az appservice label Apr 23, 2021

qwordy approved these changes Apr 23, 2021

View reviewed changes

qwordy reviewed Apr 23, 2021

View reviewed changes

calvinsID changed the title ~~[AppService] Add function to retrieve users github personal access token~~ [AppService] az appservice: Add function to retrieve users github personal access token Apr 23, 2021

calvinsID force-pushed the github-access-token branch from 9dfc04d to e6c8ae4 Compare April 23, 2021 18:45

panchagnula approved these changes Apr 23, 2021

View reviewed changes

calvinsID force-pushed the github-access-token branch from b6e1450 to 6c1e39e Compare April 26, 2021 19:01

calvinsID requested a review from qwordy April 26, 2021 19:03

calvinsID force-pushed the github-access-token branch from 6c1e39e to 3ff465c Compare April 26, 2021 19:10

calvinsID mentioned this pull request Apr 26, 2021

[AppService] az webapp deployment github-actions: Add support to add github actions to webapp Azure/azure-cli-extensions#3303

Closed

3 tasks

calvinsID force-pushed the github-access-token branch 2 times, most recently from 8b930d2 to d77d55f Compare April 27, 2021 17:24

calvinsID changed the title ~~[AppService] az appservice: Add function to retrieve users github personal access token~~ [AppService] az appservice: Add function to retrieve users github personal access token, add pieces for Github Actions support Apr 27, 2021

qwordy approved these changes Apr 29, 2021

View reviewed changes

qwordy reviewed Apr 29, 2021

View reviewed changes

yonzhan modified the milestones: S186, S187 May 1, 2021

calvinsID added 2 commits May 3, 2021 11:17

Get github token thru browser

bbe4cb0

Add comments

8ef6bfd

calvinsID added 5 commits May 3, 2021 11:17

Use url way instead of opening browser

cb846f4

Fix linter issues

9440185

CLI linter fixes

b7801d6

Add PyGithub package for github actions use later on (it will be in C…

4473316

…LI extensions repo) and github_action property in az webapp deployment source config command

add PyGithub to setup.py

fda252b

calvinsID force-pushed the github-access-token branch from 94b3dd5 to fda252b Compare May 3, 2021 15:18

calvinsID changed the title ~~[AppService] az appservice: Add function to retrieve users github personal access token, add pieces for Github Actions support~~ [AppService] az appservice: Add function to retrieve users github personal access token and add pieces for Github Actions support May 3, 2021

calvinsID changed the title ~~[AppService] az appservice: Add function to retrieve users github personal access token and add pieces for Github Actions support~~ [AppService] Add function to retrieve users github personal access token and add pieces for Github Actions support May 3, 2021

calvinsID changed the title ~~[AppService] Add function to retrieve users github personal access token and add pieces for Github Actions support~~ [AppService] Add function to retrieve users github personal access token May 3, 2021

calvinsID changed the title ~~[AppService] Add function to retrieve users github personal access token~~ [AppService] Add ability to retrieve users github personal access token May 3, 2021

calvinsID changed the title ~~[AppService] Add ability to retrieve users github personal access token~~ [AppService] az appservice: Add function to retrieve users github personal access token May 3, 2021

qwordy merged commit 2d9c7fc into Azure:dev May 7, 2021

jiasli mentioned this pull request May 7, 2021

{AppService} Fix linter error in _github_oauth.py #17998

Merged

calvinsID mentioned this pull request May 13, 2021

[AppService] Add interactive way to get token for staticwebapp #18083

Merged

3 tasks

jiasli reviewed Jun 21, 2021

View reviewed changes

jiasli mentioned this pull request Jun 25, 2021

[AppService] az webapp deployment github-actions add/remove: new commands #18261

Merged

3 tasks

bebound mentioned this pull request Dec 2, 2024

azure-cli/setup.py depends on PyGithub v1 #27873

Open

[AppService] az appservice: Add function to retrieve users github personal access token #17826

[AppService] az appservice: Add function to retrieve users github personal access token #17826

Uh oh!

Conversation

calvinsID commented Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qwordy Apr 23, 2021

Choose a reason for hiding this comment

Uh oh!

calvinsID Apr 23, 2021

Choose a reason for hiding this comment

Uh oh!

panchagnula left a comment

Choose a reason for hiding this comment

Uh oh!

qwordy commented Apr 26, 2021

Uh oh!

calvinsID commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panchagnula commented Apr 27, 2021

Uh oh!

qwordy Apr 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calvinsID Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

qwordy Apr 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

panchagnula commented May 3, 2021

Uh oh!

calvinsID commented May 3, 2021

Uh oh!

qwordy commented May 7, 2021

Uh oh!

jiasli Jun 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calvinsID Jun 21, 2021

Choose a reason for hiding this comment

Uh oh!

jiasli Jun 22, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

calvinsID commented Apr 22, 2021 •

edited

Loading

calvinsID commented Apr 26, 2021 •

edited

Loading

qwordy Apr 29, 2021 •

edited

Loading

qwordy Apr 30, 2021 •

edited

Loading

jiasli Jun 21, 2021 •

edited

Loading