Skip to content

[AppService] Fix#18033: az staticwebapp appsettings set of missing positional param app_settings #18043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwordy merged 1 commit into from
May 13, 2021
Merged

[AppService] Fix#18033: az staticwebapp appsettings set of missing positional param app_settings #18043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/appservice/static_sites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def set_staticsite_function_app_settings(cmd, name, setting_pairs, resource_grou
setting_dict[key] = value

return client.create_or_update_static_site_function_app_settings(
resource_group_name, name, kind=None, properties=setting_dict)
Copy link
Member

@qwordy qwordy May 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is kind removed? Parameter name also changed. Is it caused by SDK upgrade?

Copy link
Contributor Author

@jiansong-msft jiansong-msft May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya I think so. the latest SDK here expects parameter of app_settings rather than kind.
https://github.com/Azure/azure-sdk-for-python/blob/cac6069ae45c18810fa912327c41b7dbd452d533/sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2020_09_01/operations/_static_sites_operations.py#L1195

resource_group_name, name, app_settings=setting_dict)


def delete_staticsite_function_app_settings(cmd, name, setting_names, resource_group_name=None):
Expand All @@ -137,7 +137,7 @@ def delete_staticsite_function_app_settings(cmd, name, setting_names, resource_g
logger.warning("key '%s' not found in app settings", key)

return client.create_or_update_static_site_function_app_settings(
resource_group_name, name, kind=None, properties=app_settings)
resource_group_name, name, app_settings=app_settings)


def list_staticsite_users(cmd, name, resource_group_name=None, authentication_provider='all'):
Expand Down
8 changes: 4 additions & 4 deletions ...li/azure/cli/command_modules/appservice/tests/latest/test_staticapp_commands_thru_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def test_set_staticsite_function_app_settings_with_resourcegroup(self):
set_staticsite_function_app_settings(self.mock_cmd, self.name1, app_settings1_input, self.rg1)

self.staticapp_client.create_or_update_static_site_function_app_settings.assert_called_once_with(
self.rg1, self.name1, kind=None, properties=app_settings1_dict)
self.rg1, self.name1, app_settings=app_settings1_dict)

def test_set_staticsite_function_app_settings_without_resourcegroup(self):
app_settings1_input = ['key1=val1', 'key2=val2']
Expand All @@ -255,7 +255,7 @@ def test_set_staticsite_function_app_settings_without_resourcegroup(self):
set_staticsite_function_app_settings(self.mock_cmd, self.name1, app_settings1_input)

self.staticapp_client.create_or_update_static_site_function_app_settings.assert_called_once_with(
self.rg1, self.name1, kind=None, properties=app_settings1_dict)
self.rg1, self.name1, app_settings=app_settings1_dict)

def test_delete_staticsite_function_app_settings_with_resourcegroup(self):
# setup
Expand All @@ -273,7 +273,7 @@ class AppSettings:

# validate
self.staticapp_client.create_or_update_static_site_function_app_settings.assert_called_once_with(
self.rg1, self.name1, kind=None, properties=updated_app_settings)
self.rg1, self.name1, app_settings=updated_app_settings)

def test_delete_staticsite_function_app_settings_without_resourcegroup(self):
# setup
Expand All @@ -292,7 +292,7 @@ class AppSettings:

# validate
self.staticapp_client.create_or_update_static_site_function_app_settings.assert_called_once_with(
self.rg1, self.name1, kind=None, properties=updated_app_settings)
self.rg1, self.name1, app_settings=updated_app_settings)

def test_list_staticsite_users_with_resourcegroup(self):
authentication_provider = 'GitHub'
Expand Down