[AppService] Fix#18033: az staticwebapp appsettings set of missing positional param app_settings #18043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwordy
approved these changes
May 12, 2021
qwordy
reviewed
May 12, 2021
| setting_dict[key] = value | ||
|
|
||
| return client.create_or_update_static_site_function_app_settings( | ||
| resource_group_name, name, kind=None, properties=setting_dict) |
Member
There was a problem hiding this comment.
Is kind removed? Parameter name also changed. Is it caused by SDK upgrade?
Contributor
Author
There was a problem hiding this comment.
ya I think so. the latest SDK here expects parameter of app_settings rather than kind.
https://github.com/Azure/azure-sdk-for-python/blob/cac6069ae45c18810fa912327c41b7dbd452d533/sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2020_09_01/operations/_static_sites_operations.py#L1195
miwebst
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix#18033: az staticwebapp appsettings set of missing positional param app_settings
Testing Guide
az staticwebapp appsettings set -n staticwebappname --setting-names foo=bar
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.