Skip to content

{EventGrid}: Make identity optional for system-topic in global location and some tests #17898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 1 commit into from
Apr 28, 2021
Merged

{EventGrid}: Make identity optional for system-topic in global location and some tests #17898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/eventgrid/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ def cli_system_topic_create_or_update(
tags=None,
identity=None):

identity_info = _get_identity_info(identity)
identity_info = _get_identity_info_only_if_not_none(identity)
Copy link
Member

@evelyn-ys evelyn-ys Apr 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does domain_create_or_update need the same change(L253)?

azure-cli/src/azure-cli/azure/cli/command_modules/eventgrid/custom.py

Lines 231 to 262 in 8c04af8

def cli_domain_create_or_update(
client,
resource_group_name,
domain_name,
location=None,
tags=None,
input_schema=EVENTGRID_SCHEMA,
input_mapping_fields=None,
input_mapping_default_values=None,
public_network_access=None,
inbound_ip_rules=None,
sku=SKU_BASIC,
identity=None):
final_input_schema, input_schema_mapping = _get_input_schema_and_mapping(
input_schema,
input_mapping_fields,
input_mapping_default_values)
sku_name = _get_sku(sku)
sku_info = ResourceSku(name=sku_name)
identity_info = None
identity_info = _get_identity_info(identity)
domain_info = Domain(
location=location,
tags=tags,
input_schema=final_input_schema,
input_schema_mapping=input_schema_mapping,
public_network_access=public_network_access,
inbound_ip_rules=inbound_ip_rules,
sku=sku_info,
identity=identity_info)

Copy link
Contributor Author

@VidyaKukke VidyaKukke Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. this change is needed under some system-topics which are global.


system_topic_info = SystemTopic(
location=location,
Expand Down
900 changes: 788 additions & 112 deletions ...li/azure/cli/command_modules/eventgrid/tests/latest/recordings/test_advanced_filters.yaml
View file
Open in desktop

Large diffs are not rendered by default.

238 changes: 166 additions & 72 deletions ...odules/eventgrid/tests/latest/recordings/test_create_event_subscriptions_to_resource.yaml
View file
Open in desktop

Large diffs are not rendered by default.

289 changes: 216 additions & 73 deletions ...tgrid/tests/latest/recordings/test_create_event_subscriptions_with_20180501_features.yaml
View file
Open in desktop

Large diffs are not rendered by default.

579 changes: 267 additions & 312 deletions ...tgrid/tests/latest/recordings/test_create_event_subscriptions_with_20200101_features.yaml
View file
Open in desktop

Large diffs are not rendered by default.

179 changes: 137 additions & 42 deletions ...dules/eventgrid/tests/latest/recordings/test_create_event_subscriptions_with_filters.yaml
View file
Open in desktop

Large diffs are not rendered by default.

260 changes: 130 additions & 130 deletions ...re-cli/azure/cli/command_modules/eventgrid/tests/latest/recordings/test_create_topic.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading