{EventGrid}: Make identity optional for system-topic in global location and some tests #17898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
reviewed
Apr 28, 2021
| storage_system_topic_name_regional = self.create_random_name(prefix='cli', length=40) | ||
| policy_system_topic_name_global = 'policy-system-topic-name-global' | ||
|
|
||
| storage_account = '/subscriptions/5b4b650e-28b9-4790-b3ab-ddbd88d727c4/resourceGroups/devexprg/providers/Microsoft.Storage/storageAccounts/clistgaccount' |
Member
There was a problem hiding this comment.
Can you use @StorageAccountPreparer() to create a new storage account with random name instead of fixed storage account?
Contributor
Author
There was a problem hiding this comment.
We have some requirements on the storageaccount so we have one setup for all our tests specifically. i'm reusing that.
evelyn-ys
reviewed
Apr 28, 2021
| identity=None): | ||
|
|
||
| identity_info = _get_identity_info(identity) | ||
| identity_info = _get_identity_info_only_if_not_none(identity) |
Member
There was a problem hiding this comment.
Does domain_create_or_update need the same change(L253)?
azure-cli/src/azure-cli/azure/cli/command_modules/eventgrid/custom.py
Lines 231 to 262 in 8c04af8
Contributor
Author
There was a problem hiding this comment.
no. this change is needed under some system-topics which are global.
evelyn-ys
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not send identity for global system-topic
az eventgrid system-topic --name --location global --topic-type --source --resource-group
Added tests for some of the features introduced in 2020-10-15-preview