[Compute] sig image version create: Support data disk VHDs

[qwordy]

Description

--data-vhd, --data-vhd-luns, --data-vhd-storage-accounts

Adding test now. Please review existing part.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[houk-ms]

LGTM

[qwordy]

@olayemio I got an error. Could you have a look? Thanks!

azure.core.pipeline.policies._universal: Request URL: 'https://management.azure.com/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Compute/galleries/gallery_czbiieilm2au/images/image1/versions/1.0.0?api-version=2020-09-30'
azure.core.pipeline.policies._universal: Request method: 'PUT'
azure.core.pipeline.policies._universal: Request body:
azure.core.pipeline.policies._universal: {"location": "westus", "tags": {}, "properties": {"publishingProfile": {"targetRegions": [{"name": "westus"}], "replicaCount": 1}, "storageProfile": {"osDiskImage": {"source": {"id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Storage/storageAccounts/vhdstoragef7ab8a40af7d1f", "uri": "https://vhdstoragef7ab8a40af7d1f.blob.core.windows.net/vhds/osdisk_f7ab8a40af.vhd"}}, "dataDiskImages": [{"source": {"id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Storage/storageAccounts/clitestk5xdgk6xivqtphsvp", "uri": "https://clitestk5xdgk6xivqtphsvp.blob.core.windows.net/container1/file1.vhd"}, "lun": 0}, {"source": {"id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Storage/storageAccounts/clitestk5xdgk6xivqtphsvp", "uri": "https://clitestk5xdgk6xivqtphsvp.blob.core.windows.net/container1/file2.vhd"}, "lun": 1}]}}}

azure.core.pipeline.policies._universal: Response content:
azure.core.pipeline.policies._universal: {
  "name": "1.0.0",
  "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Compute/galleries/gallery_czbiieilm2au/images/image1/versions/1.0.0",
  "type": "Microsoft.Compute/galleries/images/versions",
  "location": "westus",
  "tags": {},
  "properties": {
    "publishingProfile": {
      "targetRegions": [
        {
          "name": "West US",
          "regionalReplicaCount": 1,
          "storageAccountType": "Standard_LRS"
        }
      ],
      "replicaCount": 1,
      "excludeFromLatest": false,
      "publishedDate": "2021-04-21T08:11:32.7607026+00:00",
      "storageAccountType": "Standard_LRS"
    },
    "storageProfile": {
      "osDiskImage": {
        "hostCaching": "ReadWrite",
        "source": {
          "uri": "https://vhdstoragef7ab8a40af7d1f.blob.core.windows.net/vhds/osdisk_f7ab8a40af.vhd",
          "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Storage/storageAccounts/vhdstoragef7ab8a40af7d1f"
        }
      },
      "dataDiskImages": [
        {
          "lun": 0,
          "hostCaching": "ReadOnly",
          "source": {
            "uri": "https://clitestk5xdgk6xivqtphsvp.blob.core.windows.net/container1/file1.vhd",
            "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Storage/storageAccounts/clitestk5xdgk6xivqtphsvp"
          }
        },
        {
          "lun": 1,
          "hostCaching": "ReadOnly",
          "source": {
            "uri": "https://clitestk5xdgk6xivqtphsvp.blob.core.windows.net/container1/file2.vhd",
            "id": "/subscriptions/0b1f6471-1bf0-4dda-aec3-cb9272f09590/resourceGroups/cli_test_gallery_image_version_vhdjhhtrrgijlkbuwn4yh3ssnxpgblbsyukyjpn533rd/providers/Microsoft.Storage/storageAccounts/clitestk5xdgk6xivqtphsvp"
          }
        }
      ]
    },
    "provisioningState": "Updating"
  }
}

Finally, it failed.

azure.core.pipeline.policies._universal: Response content:
azure.core.pipeline.policies._universal: {
  "startTime": "2021-04-21T08:11:38.9484481+00:00",
  "endTime": "2021-04-21T08:11:54.0271433+00:00",
  "status": "Failed",
  "error": {
    "code": "GalleryImageVersionInternalError",
    "message": "An internal execution error occurred. Please retry later."
  },
  "name": "442fe2fe-9ab2-4cdc-b040-262c6cb9388c"
}