[Compute] sig image-version create: Support creating from a VHD

[qwordy]

Description

Resolve #15868

[Compute] Upgrade gallery_image_versions to 2020-09-30
[Compute] sig image-version create: Support creating from a VHD

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[yonzhan]

Compute

[qwordy]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[Juliehzl]

could vhd resource in another tenant?

[qwordy]

Good question. If true, I need to add cross-tenant authentication.

[olayemio]

I have a few questions looking at the api support. So a customer using VHD will supply vhd and vhd_storage_account flag, but not the os_snapshot flag?

1. Would it be possible for customers to use the os_snapshot field for the ID of the storage account, and then a separate argument for the URI of the VHD for the OS disk?
2. Is there support for data disks to use VHD as well? data_snapshots could be used to specify the ID of the storage accounts and then a separate argument for the URI of all the VHDs

[yungezz]

hi @qwordy, what's status of this PR? is it ok to merge?

[qwordy]

1. Agree. The arguments can be better.
2. We should also support data disks.
   I plan to merge OS disk part, than put data disks in another PR.

[olayemio]

@qwordy
If you want some suggestions on the arguments, here's something I'm thinking

• for OS disk, can use --os-snapshot-uri for the VHD uri
• for data disks, since we need the storage account id and VHD uri, --data-snapshots can be used for the storage account, and the VHD can be specified using --data-vhd and --data-vhd-luns to indicate which uri match up with which storage account

[qwordy]

@olayemio How about --os-vhd, --os-vhd-storage-account, --data-vhd, --data-vhd-luns, --data-vhd-storage-accounts? Can we omit storage account? A VHD URI is unique.

[qwordy]

The OS part is done.

[olayemio]

@qwordy I propose the following --os-vhd-uri, --os-vhd-storage-account, --data-vhds-uri, --data-vhds-luns, --data-vhds-storage-accounts?
The storage account is required to ensure that there is a linked access check for the VHD

[qwordy]

Merge OS part first. Data disks will be in another PR.

[qwordy]

#17706