-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Packaging] Add azure-identity dependency #17277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| azure-cli==2.20.0 | ||
| azure-cli-core==2.20.0 | ||
| azure-cli-telemetry==1.0.6 | ||
| azure-cli==2.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorted all lines alphabetically.
|
Packaging |
DaeunYim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking care of this..!
Juliehzl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they do want to use azure-identity, I could approve for the change. But I am considering if it could utilize existing msal package for the same thing and all service could find a consistent way, which is better to have.
Anyway, approved from my side.
MSAL doesn't expose The consistent way is to use the one provided by core (#17191 (comment)) instead of developing a custom auth mechanism. |
RDBMS module uses get_mgmt_service_client for default auth but I think the predecessor also implemented a way to override the authentification using credential. I wanted to keep both ways in case users were using this approach....! Thank you so much! |
Description
RDBMS command module has its own credential logic which uses Azure Identity's
ClientSecretCredential(#17191 (comment)).Install Azure Identity so that CI can pass.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=776163&view=logs&j=36dd4138-4d53-5e46-00d9-e5cd9744be05&t=1cf3879c-0a42-5ccd-7693-7a4781d739d8&l=134