[RDBMS] Python SDK migration #17191
Merged
[RDBMS] Python SDK migration #17191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaeunYim
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft and
jiasli
as code owners
Collaborator
|
RDBMS |
jiasli
reviewed
Mar 4, 2021
jiasli
reviewed
Mar 4, 2021
...and_modules/rdbms/tests/latest/recordings/test_mysql_flexible_server_vnet_server_create.yaml
Show resolved
Hide resolved
evelyn-ys
reviewed
Mar 9, 2021
evelyn-ys
reviewed
Mar 9, 2021
evelyn-ys
reviewed
Mar 9, 2021
src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_util.py
Outdated
Show resolved
Hide resolved
evelyn-ys
reviewed
Mar 9, 2021
evelyn-ys
reviewed
Mar 9, 2021
evelyn-ys
reviewed
Mar 9, 2021
evelyn-ys
reviewed
Mar 9, 2021
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_common.py
Outdated
Show resolved
Hide resolved
evelyn-ys
reviewed
Mar 9, 2021
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_common.py
Outdated
Show resolved
Hide resolved
3 tasks
evelyn-ys
reviewed
Mar 12, 2021
evelyn-ys
approved these changes
Mar 12, 2021
jiasli
approved these changes
Mar 12, 2021
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
CI tests passed with updated network module recording files (related to rdbms single servers) |
kairu-ms
approved these changes
Mar 16, 2021
jiasli
reviewed
Apr 20, 2022
Comment on lines
+57
to
+61
| from azure.identity import ClientSecretCredential | ||
| credentials = ClientSecretCredential( | ||
| client_id=client_id, | ||
| secret=getenv(CLIENT_SECRET), | ||
| tenant=getenv(TENANT_ID)) | ||
| client_secret=getenv(CLIENT_SECRET), | ||
| tenant_id=getenv(TENANT_ID)) |
Member
There was a problem hiding this comment.
Unless AZURE_AUTHORITY_HOST is specified, this doesn't work for sovereign clouds or Azure stacks, since authority of cli_ctx is not passed to ClientSecretCredential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading the Python SDK version for rdbms to GA version (8.0.0)
Testing Guide
azdev test rdbms
History Notes
Upgraded Python SDK version to 8.0.0
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.