Skip to content

Conversation

@JunSun17
Copy link
Contributor

@JunSun17 JunSun17 commented Mar 8, 2021

Description

[AKS] az aks to use 2021-02-01 API.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@JunSun17 JunSun17 requested a review from fengzhou-msft as a code owner March 8, 2021 18:17
@yungezz yungezz added the AKS az aks/acs/openshift label Mar 9, 2021
@JunSun17 JunSun17 force-pushed the jusu/cli-vendor-2021-02-01 branch from 486d4fa to 501e561 Compare March 9, 2021 21:18
@JunSun17
Copy link
Contributor Author

JunSun17 commented Mar 9, 2021

@andyzhangx This is the 2021-02-01 API PR.

Copy link
Member

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rebase from dev

@JunSun17 JunSun17 force-pushed the jusu/cli-vendor-2021-02-01 branch from 501e561 to 411830a Compare March 10, 2021 05:14
@JunSun17
Copy link
Contributor Author

pls rebase from dev

rebased.

@yungezz yungezz changed the title az aks to use 2021-02-01 API. {Misc.} az aks to use 2021-02-01 API. Mar 10, 2021
@JunSun17 JunSun17 changed the title {Misc.} az aks to use 2021-02-01 API. [AKS] az aks to use 2021-02-01 API. Mar 10, 2021
@yungezz
Copy link
Member

yungezz commented Mar 10, 2021

@JunSun17 PR title convention https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests. SInce this will not impact command interface, you could use {AKS}

@JunSun17 JunSun17 changed the title [AKS] az aks to use 2021-02-01 API. {AKS} az aks to use 2021-02-01 API. Mar 10, 2021
@JunSun17
Copy link
Contributor Author

@JunSun17 PR title convention https://github.com/Azure/azure-cli/tree/dev/doc/authoring_command_modules#submitting-pull-requests. SInce this will not impact command interface, you could use {AKS}

Sure, changed to {AKS}

@JunSun17 JunSun17 force-pushed the jusu/cli-vendor-2021-02-01 branch from e5f256f to 91004a4 Compare March 12, 2021 21:51
@JunSun17
Copy link
Contributor Author

@fengzhou-msft The PR passed all tests, can you help to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants