WIP [AKS] az aks create: add enable-encryption-at-host parameter #17130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyzhangx
requested review from
fengzhou-msft,
jsntcy and
kairu-ms
as code owners
Contributor
Author
|
@fengzhou-msft @yungezz do you know how to trigger the CI tests? thanks. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17130 in repo Azure/azure-cli |
Contributor
Author
|
@kairu-ms could you help run test again? thanks. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
andyzhangx
force-pushed
the
aks-encryption-at-host
branch
from
3a96f6c to
b2d5908
Compare
Contributor
Author
|
would you trigger test again? thanks. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
would you trigger test again? thanks. |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17130 in repo Azure/azure-cli |
Contributor
Author
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
hi @andyzhangx we'll enable permsision to trigger CI pipeline for you soon. Recently Azure CLI got attacked via CI so we temporarily disabled it before solution ready. Pls ping me or @fengzhou-msft for CI need for now. Sorry for inconvinience. :) |
Member
|
@andyzhangx can you resolve the conflicts and take a look at the CI failures? This PR #17229 bumped API version to 2021-02-01. |
andyzhangx
changed the title
kairu-ms
approved these changes
Mar 17, 2021
Member
|
hi @andyzhangx could you pls rebase the PR? |
Contributor
Author
|
close this PR since EncryptionAtHost feature GA on AKS is postponed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
az aks createandaz aks nodepool addTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.