-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{Storage} Upgrade storage api version to 2021-01-01 #17028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b518a45
adopt new version
Juliehzl 37fbc16
use new adpi
Juliehzl 77e1c05
some test pass
Juliehzl da5d5b9
add fix for sdk
Juliehzl ddff19a
test pass
Juliehzl 0d2678c
smb test pass
Juliehzl 1af5ada
sku
Juliehzl 1bb9389
fix test in other modules
Juliehzl 0166f69
sql
Juliehzl 6f95b23
fix tests inother modules
Juliehzl ff67160
fix credential
Juliehzl 942fab0
test pass
Juliehzl 74ad95b
support storage
Juliehzl 40ceac9
Merge branch 'dev' into storage-17
Juliehzl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The allowed values still contain Standard_ZRS, Premium_LRS and Premium_ZRS in help message. They should be removed to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you are right. There are previous sku type because they are still in model definition as you can see in
https://github.com/Azure/azure-sdk-for-python/blob/09521dfb517e0859ec961cae006fb728d787b565/sdk/storage/azure-mgmt-storage/azure/mgmt/storage/v2021_01_01/models/_models_py3.py#L5088.
Here is to align with SDK, so I haven't removed them. But I will check with service team and try to fix from swagger definition.
For CLI side, I want to keep current deign with SDK first and refine with next SDK generation for the fix.