{Storage} Upgrade storage api version to 2021-01-01#17028
{Storage} Upgrade storage api version to 2021-01-01#17028
Conversation
Juliehzl
requested review from
evelyn-ys,
fengzhou-msft,
houk-ms,
jiasli,
jsntcy and
zhoxing-ms
as code owners
Juliehzl
changed the title
|
Storage |
| self.cmd('{cmd} show --account-name {sa} -g {rg}').assert_with_checks( | ||
| JMESPathCheck('shareDeleteRetentionPolicy', None)) | ||
| JMESPathCheck('shareDeleteRetentionPolicy.enabled', True), | ||
| JMESPathCheck('shareDeleteRetentionPolicy.days', 7)) |
There was a problem hiding this comment.
Can we add this breaking change into history notes so that customers can be aware?
| c.argument('sku', arg_type=get_enum_type(t_sku_name), | ||
| help='Note that the SKU name cannot be updated to Standard_ZRS, Premium_LRS or Premium_ZRS, ' | ||
| 'nor can accounts of those SKU names be updated to any other value') |
There was a problem hiding this comment.
The allowed values still contain Standard_ZRS, Premium_LRS and Premium_ZRS in help message. They should be removed to avoid confusion.
There was a problem hiding this comment.
Actually you are right. There are previous sku type because they are still in model definition as you can see in
https://github.com/Azure/azure-sdk-for-python/blob/09521dfb517e0859ec961cae006fb728d787b565/sdk/storage/azure-mgmt-storage/azure/mgmt/storage/v2021_01_01/models/_models_py3.py#L5088.
Here is to align with SDK, so I haven't removed them. But I will check with service team and try to fix from swagger definition.
For CLI side, I want to keep current deign with SDK first and refine with next SDK generation for the fix.
Juliehzl
requested review from
aim-for-better,
bgklein and
digimaun
as code owners
Juliehzl
requested review from
dpwatrous,
gingi,
idear1203,
jaredmoo,
jqhuangonearth,
paterasMSFT,
qwordy,
sunsw1994 and
yungezz
as code owners
aim-for-better
left a comment
aim-for-better
left a comment
There was a problem hiding this comment.
Approved from HDInsight part
Juliehzl
changed the title
7 participants
Description
To support new features, we have to use new package with api version 2021-01-01.
Testing Guide
History Notes
[Storage] Upgrade storage api version to 2021-01-01
[Storage] BREAKING CHANGE:
az storage account file-service-properties: Default to enable delete retention policy with retention days 7 in server sideThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.