[Privatedns] az network private-dns zone import: Raise FileOperationError instead of FileNotFoundError if zone file doesn't exist #15874
Merged
haroldrandom merged 5 commits intoAzure:devfrom Nov 12, 2020
Conversation
haroldrandom
requested review from
jsntcy,
kairu-ms and
msyyc
as code owners
added 2 commits
November 11, 2020 10:08
houk-ms
reviewed
Nov 12, 2020
| except PermissionError: | ||
| raise FileOperationError("Permission denied: " + str(file_name)) | ||
| except OSError as e: | ||
| raise UnknownError(e) |
Contributor
There was a problem hiding this comment.
We need UnclassifieduserFault here, but wait me to get this PR #15865 merged first
added 2 commits
November 12, 2020 02:43
…ithub.com:haroldrandom/azure-cli into fix-network-private-dns-import-nonactionable-bugs
haroldrandom
changed the title
haroldrandom
changed the title
haroldrandom
deleted the
fix-network-private-dns-import-nonactionable-bugs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the top 1 non-actionable bug (#14984)
Raise FileOperationError instead of FileNotFoundError if the zone file doesn't exist and catch more expected file operation related errors
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.