Conversation
houk-ms
requested review from
Juliehzl,
arrownj,
dbradish-microsoft,
fengzhou-msft,
haroldrandom,
jiasli,
jsntcy and
qwordy
as code owners
houk-ms
assigned
jiasli,
evelyn-ys,
yungezz and
fengzhou-msft and unassigned
jiasli,
evelyn-ys,
yungezz and
fengzhou-msft
|
Need adjustments for the changes in #15776 |
|
What's the difference between unclassified and unknown? The naming can be discussed. Will the error type be erased? I strongly suggest reserve the original error type. Otherwise, I don't know what's wrong given an unknown error. |
Please see the PR description for their difference. Yes, for PM's request, we may need remove the error type info. But the changes won't be applied in this release, so that we can have more time for discussion |
Co-authored-by: Yishi Wang <yishiwang@microsoft.com>
| # TODO: Fine-grained analysis here for Unknown error | ||
| az_error = azclierror.UnknownError(error_msg) | ||
| # TODO: Fine-grained analysis here | ||
| az_error = azclierror.UnclassifiedUserFault(error_msg) |
There was a problem hiding this comment.
Why CLIError here is UserFault?
There was a problem hiding this comment.
Ideally, CLIError will not show up here any more if it is deprecated.
Temporarily count the CLIError here as UserFaults for better Telemetry analysis. Because we could know almost all of the CLIErrors are UserFaults though may not 100%.
This is much better than counting CLIErrors as UnknownError. If so, a lot of userfaults are mis-categorized.
|
|
||
| class ArgumentParseError(UserFault): | ||
| """ Fallback of the argument parsing related errors. | ||
| class ArgumentUsageError(UserFault): |
There was a problem hiding this comment.
ArgumentParseError seems making more sense.
There was a problem hiding this comment.
Want use this type to cover the original UsageError, which usually are the across arguement errors. ArgumentParseError seems more like parsing issues by the name.
Error type is important. If it is removed, I can't help users resolve their issues. At least, we need to make sure error type and stack trace are available in --debug logs. @chenlomis |
8 participants
Description
This PR adjsut some error type names for error handling.
UnclassifiedUserFaultrefers to the fallback error type of UserFault. Developers could use this error type when they can not find other specific UserFault types for their error cases.UnknonwErrorrefers to an error that we could not know which category(UserFault, ServiceError, ClientError) it belongs to. This will be only used in core's exception handler for error categorizing.Testing Guide
Developer related. No changes in user experiences.