Skip to content

{CI} Use master branch of azdev and add benchmark sample to show execution time #14156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haroldrandom merged 6 commits into from
Jul 2, 2020
Merged

{CI} Use master branch of azdev and add benchmark sample to show execution time #14156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7f13c8
add execution time in CI
Jul 1, 2020
605f7a0
perf on command prefix: network vnet
Jul 1, 2020
6edbc20
change CI job title
Jul 1, 2020
40deee4
fix benchmark sample
Jul 1, 2020
16ba5a6
pip azdev of master branch instead of pypi version
Jul 2, 2020
2e6499a
becnchmark on 3.6 and 3.8
Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/templates/azdev_setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ steps:
chmod +x env/bin/activate
. env/bin/activate

pip install -q azdev
pip install -q git+https://github.com/Azure/azure-cli-dev-tools.git@master
Copy link
Contributor

@mmyyrroonn mmyyrroonn Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need use the master branch? Since azdev is our internal dev tool, it won't bring too much pros for me to use latest master branch.

Copy link
Contributor Author

@haroldrandom haroldrandom Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli comment here Azure/azure-cli-dev-tools#220 (comment).
Using the master branch could bring us a sensitive and quick sense on the change of azdev changes without release it.
I think currently, release of azdev is too much frequently.

Copy link
Collaborator

@yonzhan yonzhan Jul 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should figure out better way to handle this. azdev release process should be improved also.

azdev --version

if [ -z "$CLI_EXT_REPO_PATH" ]; then
Expand Down
26 changes: 20 additions & 6 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,19 +854,33 @@ jobs:
azdev verify history
azdev verify document-map

- job: CheckLoadPerformance
displayName: "Check Module Load Performance"

- job: PerformanceCheck
displayName: "PerformanceCheck"
strategy:
matrix:
Python36:
python.version: '3.6'
Python38:
python.version: '3.8'
pool:
vmImage: 'ubuntu-16.04'
steps:
- task: UsePythonVersion@0
displayName: 'Use Python 3.6'
displayName: 'Use Python $(python.version)'
inputs:
versionSpec: 3.6
versionSpec: '$(python.version)'
- template: .azure-pipelines/templates/azdev_setup.yml
- bash: |
. scripts/ci/install_azdev.sh
set -ev
. env/bin/activate
azdev perf load-times
displayName: "Load Performance"
- bash: |
set -ev
. env/bin/activate

azdev perf benchmark "version" "network vnet -h" "rest -h" "storage account"
displayName: "Execution Performance"

- job: CheckLinter
displayName: "Check CLI Linter"
Expand Down