{CI} Use master branch of azdev and add benchmark sample to show execution time #14156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
add to S172 |
haroldrandom
changed the title
haroldrandom
changed the title
haroldrandom
changed the title
mmyyrroonn
reviewed
Jul 2, 2020
| . env/bin/activate | ||
| pip install -q azdev | ||
| pip install -q git+https://github.com/Azure/azure-cli-dev-tools.git@master |
Contributor
There was a problem hiding this comment.
do we need use the master branch? Since azdev is our internal dev tool, it won't bring too much pros for me to use latest master branch.
Contributor
Author
There was a problem hiding this comment.
@jiasli comment here Azure/azure-cli-dev-tools#220 (comment).
Using the master branch could bring us a sensitive and quick sense on the change of azdev changes without release it.
I think currently, release of azdev is too much frequently.
Collaborator
There was a problem hiding this comment.
We should figure out better way to handle this. azdev release process should be improved also.
haroldrandom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add execution performance check on CI via
azdev perf benchmark, sampling onversioncommand andnetwork vnetsubcommandsUse master branch of azdev to avoid frequently unnecessary release. (Azure/azure-cli-dev-tools#220 (comment))
Testing Guide
https://github.com/Azure/azure-cli-dev-tools/pull/222/checks?check_run_id=825286911
After Azure/azure-cli-dev-tools#220 is megred, the CI should be fine.
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.