Skip to content

Conversation

@fengzhou-msft
Copy link
Member

@fengzhou-msft fengzhou-msft commented Feb 9, 2020

sha256sum of install.py changed due to #12000


This checklist is used to make sure that common guidelines for a pull request are followed.

@fengzhou-msft
Copy link
Member Author

fengzhou-msft commented Feb 9, 2020

I found that sha256sum of install.py calculated with git bash on windows is different from on Linux due to the fact that windows converts LF to CRLF for local files at check out (it will convert CRLF back to LF when commit).

Since this script is only used on Linux, we should use the sha256sum calculated on Linux, or use LF for files on windows before calculating sha256sum.

@fengzhou-msft fengzhou-msft changed the title {Packaging} update sha256sum of install.py {Packaging} Update sha256sum of install.py Feb 9, 2020
@fengzhou-msft fengzhou-msft self-assigned this Feb 9, 2020
@yonzhan yonzhan added this to the S165 milestone Feb 9, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 9, 2020

add to S165.

@yonzhan yonzhan requested review from jiasli and mmyyrroonn February 9, 2020 08:21
@jiasli
Copy link
Member

jiasli commented Feb 10, 2020

Followed https://help.ubuntu.com/community/HowToSHA256SUM:

$ sha256sum ~/azure-cli/scripts/curl_install_pypi/install.py
8835ac5023e292b9c3afa44f7e9a2c0058c56789114891fb921ee85fbc9c2002

@fengzhou-msft fengzhou-msft merged commit c673f94 into Azure:dev Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants