[Do Not Merge] SAP Hana backup support #10514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth7
force-pushed
the
user/t-sabhal/sapHana
branch
from
fb15d83 to
b238cd6
Compare
sambitratha
force-pushed
the
user/t-sabhal/sapHana
branch
from
b238cd6 to
e05c6c9
Compare
siddharth7
force-pushed
the
user/t-sabhal/sapHana
branch
from
c7f3db0 to
e6bd3f5
Compare
qwordy
reviewed
Sep 27, 2019
| def transform_workload_policy_show(result): | ||
| columns = [] | ||
| columns.append(('Name', result['name'])) | ||
| columns.append(('WorkloadType', result['properties']['workLoadType'])) |
Member
There was a problem hiding this comment.
columns = [
('Name', result['name']),
('WorkloadType', result['properties']['workLoadType'])
]
Maybe more readable
Collaborator
|
@qwordy please help deal with this PR. |
Member
|
Some checks were not successful. Remember to fix. |
Contributor
|
@siddharth7 Hello. Since it's a huge change, did you schedule a quick meeting before with any one of CLI team? We can have a quick meeting if you want. |
Contributor
|
Close it since a new pr appears. #11066 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.