-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Confcom Release 1.5.0 #9477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confcom Release 1.5.0 #9477
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| confcom acifragmentgen | cmd confcom acifragmentgen added parameter out_signed_fragment |
||
| confcom fragment | sub group confcom fragment added |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bundles multiple changes for the confcom extension release 1.5.0, focusing on improving fragment handling capabilities and test infrastructure improvements.
Key Changes:
- Added new CLI commands
confcom fragment pushandconfcom fragment attachfor standalone fragment operations - Enhanced
acifragmentgenwith--out-signed-fragmentflag to output signed fragments to stdout for piping - Improved test infrastructure with better certificate chain generation and Docker cleanup coordination
- Extracted BUNDLE_ID constant in Rego rules for better maintainability
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
src/confcom/setup.py |
Version bump from 1.4.5 to 1.5.0 |
src/confcom/samples/certs/create_certchain.sh |
Added support for custom output directory via optional parameter |
src/confcom/azext_confcom/tests/latest/test_confcom_virtual_node.py |
Updated cert generation to use temp directory and fixed subprocess call |
src/confcom/azext_confcom/tests/latest/test_confcom_tar.py |
Fixed temp file path to use temp directory instead of test path |
src/confcom/azext_confcom/tests/latest/test_confcom_fragment.py |
Updated cert generation to use temp directory and fixed subprocess call |
src/confcom/azext_confcom/tests/latest/test_confcom_arm.py |
Added Docker prune coordination with file locking to prevent xdist conflicts |
src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py |
New comprehensive tests for fragment generation, signing, and upload features |
src/confcom/azext_confcom/data/rules.rego |
Extracted BUNDLE_ID constant and added validation for bundle_id format |
src/confcom/azext_confcom/data/genpolicy-settings.json |
New configuration file with default policy settings for containers and volumes |
src/confcom/azext_confcom/custom.py |
Added fragment push/attach functions and --out-signed-fragment support |
src/confcom/azext_confcom/commands.py |
Registered new fragment push and attach commands |
src/confcom/azext_confcom/command/fragment_push.py |
New command implementation for pushing fragments to registry |
src/confcom/azext_confcom/command/fragment_attach.py |
New command implementation for attaching fragments to images |
src/confcom/azext_confcom/_params.py |
Added parameter definitions for new fragment commands |
src/confcom/azext_confcom/_help.py |
Added help documentation for new fragment commands |
src/confcom/HISTORY.rst |
Release notes for version 1.5.0 |
linter_exclusions.yml |
Excluded positional parameter warnings for fragment commands |
src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py
Outdated
Show resolved
Hide resolved
src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py
Outdated
Show resolved
Hide resolved
src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py
Outdated
Show resolved
Hide resolved
Addresses - Azure#9222 - [x] Update the code to restore the "attach to first image in input" behaviour - [x] Add two new commands: `fragment push` and `fragment attach` to allow the user to explicitly do one or the other (or both!) - [x] Add new tests which run a local docker registry, and test that the fragments are generated, signed, pushed and attached as expected (as well as the default behaviour) --- This checklist is used to make sure that common guidelines for a pull request are followed. <!--- Please provide the related command with az {command} if you can, so that we can quickly route to the related person to review. ---> - [x] Have you run `azdev style <YOUR_EXT>` locally? (`pip install azdev` required) - [x] Have you run `python scripts/ci/test_index.py -q` locally? (`pip install wheel==0.30.0` required) - [x] My extension version conforms to the [Extension version schema](https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md)
|
[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/msazure/One/_build/results?buildId=146898724&view=results |
Why
This PR contains all currently ready PRs for the confcom extension. They are grouped together to speed up merging and releasing time.
How
The only commits in this PR should be merged PRs for individual changes, and merges from main.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)