[confcom] Restore the behaviour of --upload-fragment for acifragmentgen#9223
[confcom] Restore the behaviour of --upload-fragment for acifragmentgen#9223DomAyre wants to merge 26 commits intoAzure:mainfrom
--upload-fragment for acifragmentgen#9223Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| confcom acifragmentgen | cmd confcom acifragmentgen added parameter out_signed_fragment |
||
| confcom fragment | sub group confcom fragment added |
|
Hi @DomAyre, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR restores the behaviour of the --upload-fragment flag for acifragmentgen and adds two new command-line arguments for more explicit control over fragment operations.
- Restores the default behavior of
--upload-fragmentto attach fragments to the first image in the input - Adds
--push-fragment-toand--attach-fragment-toarguments for explicit fragment operations - Updates the certificate generation script to support custom output directories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/confcom/samples/certs/create_certchain.sh | Enhanced to accept an optional output directory parameter |
| src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py | Added comprehensive tests using local Docker registry for fragment generation, signing, uploading, pushing, and attaching |
| src/confcom/azext_confcom/custom.py | Restored default upload behavior and added support for new push/attach parameters |
| src/confcom/azext_confcom/_params.py | Added command-line argument definitions for the new fragment operation parameters |
|
--upload-fragment for acifragmentgen--upload-fragment for acifragmentgen
aa29452 to
9788e7d
Compare
…standalone fragments
38cec96 to
62ad4f2
Compare
|
Folded into #9477 |
Why
Addresses
--upload-fragment#9222How
fragment pushandfragment attachto allow the user to explicitly do one or the other (or both!)This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)