-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Enable NFS Azure file Storage for managed environment #7155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable NFS Azure file Storage for managed environment #7155
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env storage set | cmd containerapp env storage set added parameter server |
||
| containerapp env storage set | cmd containerapp env storage set added parameter storage_type |
||
| containerapp env storage set | cmd containerapp env storage set update parameter access_mode: removed property required=True |
||
| containerapp env storage set | cmd containerapp env storage set update parameter azure_file_account_key: removed property required=True |
||
| containerapp env storage set | cmd containerapp env storage set update parameter azure_file_account_name: removed property required=True |
||
| containerapp env storage set | cmd containerapp env storage set update parameter azure_file_share_name: removed property required=True |
|
Hi @LaylaLiu-gmail, |
|
Hi @LaylaLiu-gmail, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
1f24186 to
62a8a51
Compare
d6ed850 to
8eab727
Compare
src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_create_update_with_yaml.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerappjob_with_yaml.py
Outdated
Show resolved
Hide resolved
6857e28 to
80ab995
Compare
f1b73be to
9146af8
Compare
b595eb8 to
49bd999
Compare
49bd999 to
1af7235
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp env storage set
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.