Skip to content

Conversation

@berndverst
Copy link
Member

@berndverst berndverst commented Jan 30, 2024


Azure Container Apps: Adds support for Circuit Breakers in Dapr Component Resiliency (new properties available in API 2023-11-02-preview)

Related command

az containerapp env dapr-component resiliency create and az containerapp env dapr-component resiliency update have been updated with new flags. See help command.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

- [] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jan 30, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency create cmd containerapp env dapr-component resiliency create added parameter in_circuit_breaker_consecutive_errors
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency create cmd containerapp env dapr-component resiliency create added parameter in_circuit_breaker_interval
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency create cmd containerapp env dapr-component resiliency create added parameter in_circuit_breaker_timeout
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency create cmd containerapp env dapr-component resiliency create added parameter out_circuit_breaker_consecutive_errors
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency create cmd containerapp env dapr-component resiliency create added parameter out_circuit_breaker_interval
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency create cmd containerapp env dapr-component resiliency create added parameter out_circuit_breaker_timeout
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency update cmd containerapp env dapr-component resiliency update added parameter in_circuit_breaker_consecutive_errors
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency update cmd containerapp env dapr-component resiliency update added parameter in_circuit_breaker_interval
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency update cmd containerapp env dapr-component resiliency update added parameter in_circuit_breaker_timeout
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency update cmd containerapp env dapr-component resiliency update added parameter out_circuit_breaker_consecutive_errors
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency update cmd containerapp env dapr-component resiliency update added parameter out_circuit_breaker_interval
⚠️ 1006 - ParaAdd containerapp env dapr-component resiliency update cmd containerapp env dapr-component resiliency update added parameter out_circuit_breaker_timeout

@azure-client-tools-bot-prd
Copy link

Hi @berndverst,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @berndverst,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 30, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@berndverst berndverst changed the title Containerapp/daprcomponentresiliencycbs Container Apps Extension: Add Circuit Breaker Support for Dapr Component Resiliency Jan 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 30, 2024
@berndverst berndverst force-pushed the containerapp/daprcomponentresiliencycbs branch from 257a71d to 360c89c Compare January 30, 2024 08:35
@Greedygre
Copy link
Contributor

Hi @yash-nisar

Please help to review and approve this PR about Dapr component.

@berndverst berndverst requested a review from yash-nisar January 31, 2024 20:10
@berndverst
Copy link
Member Author

@Greedygre the integration tests seem to fail with a service binding / springboard related issue. No idea what's happening there.

The following passes:

azdev test --discover --no-exitfirst --live azext_containerapp.ContainerappResiliencyTests
azdev test --discover --no-exitfirst --live azext_containerapp.DaprComponentResiliencyTests

Copy link
Contributor

@yash-nisar yash-nisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because the test failures seem to be unrelated.

Signed-off-by: Bernd Verst <[email protected]>
@berndverst
Copy link
Member Author

FYI the unrelated failure is:

WARNING  cli.azure.cli.core.commands:__init__.py:816 The behavior of this command has been altered by the following extension: containerapp
ERROR    cli.azure.cli.core.azclierror:azlogging.py:212 'service' is misspelled or not recognized by the system.
ERROR    az_command_data_logger:azlogging.py:213 'service' is misspelled or not recognized by the system.

caused by:

>       self.cmd('containerapp service redis create -g {} -n {} --environment {}'.format(env_rg, redis_ca_name, env_name), checks=[
            JMESPathCheck('properties.provisioningState', "Succeeded")
        ])

@Greedygre
Copy link
Contributor

FYI the unrelated failure is:

WARNING  cli.azure.cli.core.commands:__init__.py:816 The behavior of this command has been altered by the following extension: containerapp
ERROR    cli.azure.cli.core.azclierror:azlogging.py:212 'service' is misspelled or not recognized by the system.
ERROR    az_command_data_logger:azlogging.py:213 'service' is misspelled or not recognized by the system.

caused by:

>       self.cmd('containerapp service redis create -g {} -n {} --environment {}'.format(env_rg, redis_ca_name, env_name), checks=[
            JMESPathCheck('properties.provisioningState', "Succeeded")
        ])

Hi, I will fix this I issue in this PR: https://github.com/Azure/azure-cli-extensions/pull/7236/files

@Greedygre
Copy link
Contributor

Please resolve the conflicts.

@berndverst berndverst requested a review from Greedygre February 19, 2024 18:03
@berndverst
Copy link
Member Author

@Greedygre feedback addressed. Thanks!

@yanzhudd yanzhudd merged commit b921a77 into Azure:main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants