-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[containerapp] Revert remove deprecate command az containerapp env workload-profile set
#6977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -572,6 +572,15 @@ | |
| az containerapp auth update -g myResourceGroup --name MyContainerapp --proxy-convention Standard | ||
| """ | ||
|
|
||
| helps['containerapp env workload-profile set'] = """ | ||
| type: command | ||
| short-summary: Create or update an existing workload profile in a Container Apps environment | ||
| examples: | ||
| - name: Create or update an existing workload profile in a Container Apps environment | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. have to be existing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean existing is not required in description |
||
| text: | | ||
| az containerapp env workload-profile set -g MyResourceGroup -n MyEnvironment --workload-profile-name my-wlp --workload-profile-type D4 --min-nodes 1 --max-nodes 2 | ||
| """ | ||
|
|
||
| # Compose commands | ||
| helps['containerapp compose'] = """ | ||
| type: group | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1088,6 +1088,10 @@ def create_containerapps_from_compose(cmd, # pylint: disable=R0914 | |
| return containerapps_from_compose | ||
|
|
||
|
|
||
| def set_workload_profile(cmd, resource_group_name, env_name, workload_profile_name, workload_profile_type=None, min_nodes=None, max_nodes=None): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we have test for the command?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add test in |
||
| return update_managed_environment(cmd, env_name, resource_group_name, workload_profile_type=workload_profile_type, workload_profile_name=workload_profile_name, min_nodes=min_nodes, max_nodes=max_nodes) | ||
|
|
||
|
|
||
| def patch_list(cmd, resource_group_name=None, managed_env=None, show_all=False): | ||
| # Ensure that Docker is running locally before attempting to use the pack CLI | ||
| if is_docker_running() is False: | ||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you add deprecation_info here?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add in the deprecate info for command setting:
