[containerapp] Revert remove deprecate command az containerapp env workload-profile set#6977
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env workload-profile set | cmd containerapp env workload-profile set added |
|
Hi @Greedygre, |
|
Hi @Greedygre, |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yanzhudd and
zhoxing-ms
|
containerapp |
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto and
vturecek
|
|
||
| helps['containerapp env workload-profile set'] = """ | ||
| type: command | ||
| short-summary: Create or update an existing workload profile in a Container Apps environment |
There was a problem hiding this comment.
should you add deprecation_info here?
There was a problem hiding this comment.
Add in the deprecate info for command setting:
| type: command | ||
| short-summary: Create or update an existing workload profile in a Container Apps environment | ||
| examples: | ||
| - name: Create or update an existing workload profile in a Container Apps environment |
There was a problem hiding this comment.
update an existing workload profile, create a new one is ok too.
There was a problem hiding this comment.
I mean existing is not required in description
| g.custom_command('create', 'create_containerapps_from_compose') | ||
|
|
||
| with self.command_group('containerapp env workload-profile') as g: | ||
| g.custom_command('set', 'set_workload_profile', deprecate_info=g.deprecate(hide=True)) |
There was a problem hiding this comment.
Can not add redirect, because set = update + add:
command set support to create a new workload profile or update an existing one.
But command add only support add a new one, if the added name has been used, throw validate error;
command update only support update an existing one, if not existing, throw error.
| return containerapps_from_compose | ||
|
|
||
|
|
||
| def set_workload_profile(cmd, resource_group_name, env_name, workload_profile_name, workload_profile_type=None, min_nodes=None, max_nodes=None): |
There was a problem hiding this comment.
do we have test for the command?
There was a problem hiding this comment.
Add test in test_containerapp_env_workload_profiles_e2e_no_waits
|
Hi @zhoxing-ms |
4 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.