Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/containerapp/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ upcoming
* Add command group 'az containerapp connected-env dapr-component', support list/show/set/remove connectedEnvironments daprComponents
* Add command group 'az containerapp connected-env storage', support list/show/set/remove connectedEnvironments storage
* 'az containerapp env': --infrastructure-resource-group, supports custom rg name for byovnet env creations in WP enabled envs
* 'az containerapp job create': update default properties
Comment thread
p-bouchon marked this conversation as resolved.
Outdated

0.3.39
++++++
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,9 @@ def validate_arguments(self):
validate_container_app_name(self.get_argument_name(), AppType.ContainerAppJob.name)
validate_create(self.get_argument_registry_identity(), self.get_argument_registry_pass(), self.get_argument_registry_user(), self.get_argument_registry_server(), self.get_argument_no_wait())
if self.get_argument_yaml() is None:
if self.get_argument_replica_timeout() is None:
raise RequiredArgumentMissingError('Usage error: --replica-timeout is required')

if self.get_argument_replica_retry_limit() is None:
raise RequiredArgumentMissingError('Usage error: --replica-retry-limit is required')
if self.get_argument_trigger_type() is None:
Comment thread
p-bouchon marked this conversation as resolved.
Outdated
raise RequiredArgumentMissingError('Usage error: --trigger-type is required')

if self.get_argument_managed_env() is None:
raise RequiredArgumentMissingError('Usage error: --environment is required if not using --yaml')
Expand Down Expand Up @@ -278,7 +276,7 @@ def construct_payload(self):
eventTriggerConfig_def = None
if self.get_argument_trigger_type is not None and self.get_argument_trigger_type().lower() == "event":
Comment thread
p-bouchon marked this conversation as resolved.
Outdated
scale_def = None
if self.get_argument_min_executions() is not None or self.get_argument_max_executions() is not None or self.get_argument_polling_interval() is not None:
if self.get_argument_min_executions() or self.get_argument_max_executions() or self.get_argument_polling_interval():
scale_def = JobScaleModel
scale_def["pollingInterval"] = self.get_argument_polling_interval()
scale_def["minExecutions"] = self.get_argument_min_executions()
Expand Down
14 changes: 7 additions & 7 deletions src/containerapp/azext_containerapp/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -807,10 +807,10 @@ def create_containerappsjob(cmd,
container_name=None,
managed_env=None,
trigger_type=None,
replica_timeout=None,
replica_retry_limit=None,
replica_completion_count=None,
parallelism=None,
replica_timeout=1800,
replica_retry_limit=0,
replica_completion_count=1,
parallelism=1,
cron_expression=None,
secrets=None,
env_vars=None,
Expand All @@ -825,9 +825,9 @@ def create_containerappsjob(cmd,
scale_rule_name=None,
scale_rule_type=None,
scale_rule_auth=None,
polling_interval=None,
min_executions=None,
max_executions=None,
polling_interval=30,
min_executions=0,
max_executions=10,
tags=None,
no_wait=False,
system_assigned=False,
Expand Down
Loading