[containerapp] az containerapp job create: Add default values for properties #6789

p-bouchon · 2023-09-20T18:59:08Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

'az containerapp job create'

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2023-09-20T18:59:11Z

Hi @p-bouchon,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

azure-client-tools-bot-prd · 2023-09-20T18:59:14Z

Hi @p-bouchon,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2023-09-20T18:59:17Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1008 - ParaPropAdd containerapp job create cmd containerapp job create update parameter max_executions: added property default=100

⚠️ 1008 - ParaPropAdd containerapp job create cmd containerapp job create update parameter parallelism: added property default=1

⚠️ 1008 - ParaPropAdd containerapp job create cmd containerapp job create update parameter polling_interval: added property default=30

⚠️ 1008 - ParaPropAdd containerapp job create cmd containerapp job create update parameter replica_completion_count: added property default=1

⚠️ 1008 - ParaPropAdd containerapp job create cmd containerapp job create update parameter replica_timeout: added property default=1800

yonzhan · 2023-09-20T18:59:21Z

Thank you for your contribution! We will review the pull request and get back to you soon.

src/containerapp/HISTORY.rst

yanzhudd · 2023-09-26T08:49:03Z

If you want to release a new version of the extension, please change the version in setup.py as well.

Greedygre · 2023-09-26T15:11:31Z

Recommend PR title:
[containerapp] az containerapp job create: Add default values for properties

src/containerapp/azext_containerapp/_params.py

src/containerapp/azext_containerapp/containerapp_job_decorator.py

Greedygre · 2023-10-06T02:02:08Z

Defaults defined here

Please do not paste the internal link.

src/containerapp/azext_containerapp/containerapp_job_decorator.py

Greedygre · 2023-10-11T02:07:50Z

src/containerapp/azext_containerapp/containerapp_job_decorator.py

+        if self.get_argument_trigger_type() is None:
+            raise RequiredArgumentMissingError('Usage error: --trigger-type is required')
+        return super().validate_arguments()


Suggested change

if self.get_argument_trigger_type() is None:

raise RequiredArgumentMissingError('Usage error: --trigger-type is required')

return super().validate_arguments()

super().validate_arguments()

if self.get_argument_yaml() is None:

if self.get_argument_trigger_type() is None:

raise RequiredArgumentMissingError('Usage error: --trigger-type is required')

With --yaml, the --trigger-type is not required, right?

Greedygre · 2023-10-11T08:52:06Z

Hi @yanzhudd @zhoxing-ms
Could you help to review this PR when you have chance? Thanks.

yanzhudd · 2023-10-12T05:28:19Z

src/containerapp/azext_containerapp/_params.py

+        c.argument('replica_completion_count', type=int, options_list=['--replica-completion-count', '--rcc'], help='Number of replicas that need to complete successfully for execution to succeed', default=1)
+        c.argument('replica_retry_limit', type=int, help='Maximum number of retries before the replica fails. Default: 0.', default=0)
+        c.argument('replica_timeout', type=int, help='Maximum number of seconds a replica can execute', default=1800)
+        c.argument('parallelism', type=int, help='Maximum number of replicas to run per execution', default=1)
+        c.argument('min_executions', type=int, help="Minimum number of job executions that are created for a trigger. Default: 0.", default=0)
+        c.argument('max_executions', type=int, help="Maximum number of job executions that are created for a trigger", default=100)
+        c.argument('polling_interval', type=int, help="Interval to check each event source in seconds.", default=30)


May I ask if these params are new added and have been tested?

Yes, Tested in new added test test_containerapp_manualjob_defaults_e2e.

src/containerapp/HISTORY.rst

…perties (Azure#6789)

Patrick Bouchon added 3 commits September 20, 2023 10:20

update defaults

a2ce9f8

add tests for job defaults

922deba

update history

b542e10

azure-client-tools-bot-prd bot added this to the October 2023 (2023-11-15) milestone Sep 20, 2023

microsoft-github-policy-service bot requested review from wangzelin007, yanzhudd, yonzhan and zhoxing-ms September 20, 2023 18:59

microsoft-github-policy-service bot requested review from Greedygre, JennyLawrance, Juliehzl, chinadragon0515, ebencarek, howang-ms, jijohn14, jsntcy, pagariyaalok, ruslany, sanchitmehta, torosent, vinisoto and vturecek September 20, 2023 18:59

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Sep 20, 2023

microsoft-github-policy-service bot assigned zhoxing-ms Sep 20, 2023

microsoft-github-policy-service bot added the ContainerApp label Sep 20, 2023

p-bouchon changed the title ~~Pbouchon/jobs~~ Add container app job create default properties Sep 20, 2023

vinisoto approved these changes Sep 25, 2023

View reviewed changes

yanzhudd reviewed Sep 26, 2023

View reviewed changes

src/containerapp/HISTORY.rst Outdated Show resolved Hide resolved

Patrick Bouchon added 2 commits September 26, 2023 09:59

bump to version 0.3.40

d86a774

fix version conflict

44060f1

p-bouchon changed the title ~~Add container app job create default properties~~ [containerapp] az containerapp job create: Add default values for properties Sep 26, 2023

Greedygre reviewed Sep 26, 2023

View reviewed changes

src/containerapp/azext_containerapp/_params.py Outdated Show resolved Hide resolved

Patrick Bouchon added 3 commits September 26, 2023 19:13

remove redundant default help text

2efbece

fix updates having defaults

ace8d12

fix other defaults

66e1103

Greedygre approved these changes Oct 6, 2023

View reviewed changes

Greedygre reviewed Oct 6, 2023

View reviewed changes

src/containerapp/azext_containerapp/containerapp_job_decorator.py Outdated Show resolved Hide resolved

Greedygre reviewed Oct 8, 2023

View reviewed changes

src/containerapp/azext_containerapp/containerapp_job_decorator.py Outdated Show resolved Hide resolved

Patrick Bouchon added 3 commits October 10, 2023 10:04

update trigger type checks

837f719

fix merge

c85fd82

fix jobs default test

917e19f

Greedygre reviewed Oct 11, 2023

View reviewed changes

fix yaml check

d60610a

Greedygre approved these changes Oct 11, 2023

View reviewed changes

yanzhudd reviewed Oct 12, 2023

View reviewed changes

src/containerapp/HISTORY.rst Outdated Show resolved Hide resolved

Update src/containerapp/HISTORY.rst

55590d9

yanzhudd approved these changes Oct 12, 2023

View reviewed changes

yanzhudd merged commit edfe5b6 into Azure:main Oct 12, 2023

scrappywyrm pushed a commit to scrappywyrm/azure-cli-extensions that referenced this pull request Oct 16, 2023

[containerapp] az containerapp job create: Add default values for pro…

f81811e

…perties (Azure#6789)

[containerapp] az containerapp job create: Add default values for properties #6789

[containerapp] az containerapp job create: Add default values for properties #6789

Uh oh!

Conversation

p-bouchon commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Sep 20, 2023

Uh oh!

azure-client-tools-bot-prd bot commented Sep 20, 2023

Uh oh!

azure-client-tools-bot-prd bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Sep 20, 2023

Uh oh!

Uh oh!

yanzhudd commented Sep 26, 2023

Uh oh!

Greedygre commented Sep 26, 2023

Uh oh!

Uh oh!

Uh oh!

Greedygre commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Greedygre Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Greedygre Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Greedygre commented Oct 11, 2023

Uh oh!

yanzhudd Oct 12, 2023

Choose a reason for hiding this comment

Uh oh!

Greedygre Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

p-bouchon commented Sep 20, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Sep 20, 2023 •

edited

Loading

Greedygre commented Oct 6, 2023 •

edited

Loading

Greedygre Oct 12, 2023 •

edited

Loading