-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Spring] Add addon configs & allowedOriginPatterns & restart for Spring Cloud Gateway #6412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -861,6 +861,10 @@ def prepare_logs_argument(c): | |
| help='Sensitive properties for environment variables. Once put, it will be encrypted and not returned.' | ||
| 'Format "key[=value]" and separated by space.') | ||
| c.argument('allowed_origins', arg_group='Cross-origin Resource Sharing (CORS)', help="Comma-separated list of allowed origins to make cross-site requests. The special value `*` allows all domains.") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
It is recommended to keep the naming of parameter
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As talked offline, we will keep the name consistent with other parameters first, which is referenced from VMware's product Spring Cloud Gateway. Later will consider to deprecate those parameters together. |
||
| c.argument('allowed_origin_patterns', | ||
| arg_group='Cross-origin Resource Sharing (CORS)', | ||
| options_list=['--allowed-origin-patterns', '--allow-origin-patterns'], | ||
|
ninpan-ms marked this conversation as resolved.
|
||
| help="Comma-separated list of allowed origin patterns to make cross-site requests.") | ||
| c.argument('allowed_methods', arg_group='Cross-origin Resource Sharing (CORS)', help="Comma-separated list of allowed HTTP methods on cross-site requests. The special value `*` allows all methods.") | ||
| c.argument('allowed_headers', arg_group='Cross-origin Resource Sharing (CORS)', help="Comma-separated list of allowed headers in cross-site requests. The special value `*` allows actual requests to send any header.") | ||
| c.argument('max_age', arg_group='Cross-origin Resource Sharing (CORS)', type=int, | ||
|
|
@@ -873,6 +877,8 @@ def prepare_logs_argument(c): | |
| options_list=['--enable-certificate-verification', '--enable-cert-verify'], | ||
| help='If true, will verify certificate in TLS connection from gateway to app.') | ||
| c.argument('certificate_names', arg_group='Client Certificate Authentication', help="Comma-separated list of certificate names in Azure Spring Apps.") | ||
| c.argument('addon_configs_json', arg_group='Add-on Configurations', help="JSON string of add-on configurations.") | ||
| c.argument('addon_configs_file', arg_group='Add-on Configurations', help="The file path of JSON string of add-on configurations.") | ||
|
|
||
| for scope in ['spring gateway custom-domain', | ||
| 'spring api-portal custom-domain']: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "javaopts": "-Djava.awt.headless=true", | ||
| "sso": { | ||
| "rolesAttributeName": "role", | ||
| "inactiveSessionExpirationInMinutes": 1 | ||
| }, | ||
| "envs": [ | ||
| { | ||
| "name": "xxx", | ||
| "value": "yyy" | ||
| }, | ||
| { | ||
| "name": "xxx1", | ||
| "value": "yyy" | ||
| } | ||
| ] | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.