Skip to content

Conversation

@ninpan-ms
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @ninpan-ms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 16, 2023

Spring

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Copy link
Contributor

@zhoxing-ms zhoxing-ms Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, it is recommended to deprecate and hide the existing parameter --allowed-origins and replace it with a new parameter --allow-origins

It is recommended to keep the naming of parameter allowed_origins consistent with parameter allowed_origin_patterns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As talked offline, we will keep the name consistent with other parameters first, which is referenced from VMware's product Spring Cloud Gateway. Later will consider to deprecate those parameters together.

@zhoxing-ms zhoxing-ms merged commit e882845 into Azure:main Jun 19, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=65347&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants