Skip to content

[SSH] SSHArc Public Preview #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiasli merged 98 commits into from
Apr 15, 2022
Merged

[SSH] SSHArc Public Preview #4570

jiasli merged 98 commits into from
Apr 15, 2022

Conversation

@vthiebaut10
Copy link
Contributor

@vthiebaut10 vthiebaut10 commented Mar 24, 2022

  • Add support for connecting to Arc Server using AAD Certificate and Local User credentials
  • New command: az ssh arc
  • New parameters: --resource-type and --ssh-proxy-folder.
  • Vendored SDKs: hybridcompute and hybridconnectivity

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

vthiebaut10 and others added 30 commits September 29, 2021 15:56
@vthiebaut10
Moving SSHArc changes from private repo to the public repo
8ae508f
@vthiebaut10
Fix linter exclusions
75aab5c
@vthiebaut10
Added license header to constants file
74c35d7
@vthiebaut10
Fixed the local user parameter options for the config command
af62216
@vthiebaut10
Changed --local-user-name to --local-user for the config command
12e1c15
@vthiebaut10
Host for arc servers on config is not rg-vm instead of just vm
5c9170c
@vthiebaut10
Merge branch 'Azure:main' into ssharc
2601ea2
@vthiebaut10
Merge origin
67c61e1
@vthiebaut10
Add HostName to arc config files
1eb2100
@vthiebaut10
Fixed config tests
53e4cd2
@vthiebaut10
Include OS and architecture in the proxy filename
0c08a46
@vthiebaut10
Stop throwing exception immediately if user not authorized to get vm …
7c99a1e 
…or arc server
@vthiebaut10
Merge pull request #8 from vthiebaut10/ssharc-exceptionhandling
b89a631 
Handle unauthorized exception
@vthiebaut10
addind hybridconnectivity
be6ffb2
@vthiebaut10
Change hybrid connectivity SDK to be subscription bound
be11b71
@vthiebaut10
Adjust request for access details
adb6237
@vthiebaut10
Using the latest stable version of connected machines sdk
5411e7e
@vthiebaut10
Merge pull request #9 from vthiebaut10/ssharc-v2-hybridconnectivity
2029802 
Ssharc v2 hybridconnectivity
@vthiebaut10
add a exception handling to requesting relay info
61d7a66
@vthiebaut10
Initial changes to clean up credentials on ssh arc
d4d8b53
@vthiebaut10
Fixing a few bugs
337a5ce
@vthiebaut10
clean-up credentials
d317d35
@vthiebaut10
config for arc no longer create temp folder for relay if there isn't …
206ac44 
…a cert and a priv key
@vthiebaut10
Clean up, resource type param, and tests
5ba2fb6
@vthiebaut10
Add ssharc telemetry
32273d3
@vthiebaut10
Style fixes
f814e06
@vthiebaut10
Changed some Telemetry data points names
cac0a79
@vthiebaut10
Debug logs with OS and architecture
426971a
@vthiebaut10
Address comments
5e3977e
@vthiebaut10
Merge pull request #13 from vthiebaut10/ssharc-v2-cleanup-removeid-te…
ec0900d 
…lemetry

SSHArc Private Preview 2
vthiebaut10 and others added 16 commits March 28, 2022 11:03
@vthiebaut10
Change cleanup logic
e4029ce
@vthiebaut10
A few final improvements
9a5daa0
@vthiebaut10
Fix cleanup logic
b9f1bba
@vthiebaut10
Address review comments. Change ACL of generated files, search for pr…
c27f6e7 
…ivate key if not provided, add username to Host name of certs for local user login (possible breaking change?)
@vthiebaut10
Catch stderr
7acea38
@vthiebaut10
Improve help, remove explicit exception telemetry, a few changes
2a935e7
@vthiebaut10
Address review comments
0756512
@vthiebaut10
Change ssh not found error message
5125936
@vthiebaut10
Fix help and add localuser name to ip entry
f63ec2c
@vthiebaut10
help improvements
abd4a28
@vthiebaut10
Add ssh not found error recommendation to constants
fb61c79
@vthiebaut10
Make sure we capture stderr only when log is not supposed to be displyed
24bdef4
@vthiebaut10
update tests, help, and style
39be94f
@vthiebaut10
Merge pull request #25 from vthiebaut10/ssharc-proxyerror
e224c70 
SSHArc Public Preview improvements
@vthiebaut10
Fix linter tests
f7769b8
@vthiebaut10
Improve some error messages
8c130f2
jiasli
jiasli reviewed Apr 13, 2022
View reviewed changes
@yonzhan yonzhan requested review from jsntcy and zhoxing-ms April 13, 2022 12:59
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 13, 2022

SSH

@jiasli jiasli merged commit 5bc3a8f into Azure:main Apr 15, 2022
@jkroepke jkroepke mentioned this pull request Apr 18, 2022
Closed
2 tasks
@zhoxing-ms zhoxing-ms mentioned this pull request May 30, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiasli jiasli jiasli approved these changes

@kairu-ms kairu-ms Awaiting requested review from kairu-ms kairu-ms is a code owner

@yonzhan yonzhan Awaiting requested review from yonzhan

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@jsntcy jsntcy Awaiting requested review from jsntcy

+1 more reviewer

@bagajjal bagajjal bagajjal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jiasli jiasli

Labels

Auto-Assign Auto assign by bot VM SSH

Projects

None yet

Milestone

Mar 2022 (2022-04-06)

Development

Successfully merging this pull request may close these issues.

4 participants

@vthiebaut10 @yonzhan @jiasli @bagajjal