Allow alternate ssh distributions #3649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
customer-reported
|
Thank you for your contribution jkroepke! We will review the pull request and get back to you soon. |
Author
|
Please let me know, if the code solution is fine. If yes, I take a look at the ITs |
yonzhan
requested review from
Juliehzl,
jiasli and
zhoxing-ms
and removed request for
fengzhou-msft
Collaborator
|
ssh |
Author
|
Any update to this? |
jiasli
requested review from
N6UDP
and removed request for
Juliehzl,
jiasli and
zhoxing-ms
Author
Author
|
Hi, did we miss the milestone again? |
Author
|
Superseeded by #4570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our company does not have the windows 10 ssh client installed. As user we not allowed to install such windows features. But we are able to provide ssh-keygen.exe on different ways. The ssh-keygen.exe command is inside our path, but the az cli forcefully look into C:\SysNative\OpenSSH.
This PR add a fallback on Windows systems, in case
C:\SysNative\OpenSSHis not present, the ssh command from the PATH should be used.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.