Skip to content

Vmware 4.0.0 publish #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 9 commits into from
Nov 21, 2021
Merged

Vmware 4.0.0 publish #4127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
02af3cf
added warning message for private cloud rotate password commands
jonathanhe-msft Nov 5, 2021
918a179
unit tests
jonathanhe-msft Nov 5, 2021
6a96d7f
Merge branch 'main' into jonathanhe/private-cloud-rotate-password
jonathanhe-msft Nov 15, 2021
47e7d11
added prompt for all delete commands
jonathanhe-msft Nov 15, 2021
eee3e8f
changed deletes to delete for parameter help text
jonathanhe-msft Nov 17, 2021
b1fe878
4.0.0 publish
jonathanhe-msft Nov 18, 2021
376bd3f
Merge branch 'main' into jonathanhe/private-cloud-rotate-password
jonathanhe-msft Nov 18, 2021
ac1dc70
updated version number
jonathanhe-msft Nov 18, 2021
01c7409
added unit tests for private-cloud identity command group
jonathanhe-msft Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vmware/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Add `az vmware private-cloud list-admin-credentials`
- Add `az vmware private-cloud add-identity-source`
- Add `az vmware private-cloud delete-identity-source`
- Add `az vmware private-cloud identity` command group
- Deprecate `az vmware private-cloud listadmincredentials`
- Deprecate `az vmware private-cloud addidentitysource`
- Deprecate `az vmware private-cloud deleteidentitysource`
Expand Down
2 changes: 1 addition & 1 deletion src/vmware/azext_vmware/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def privatecloud_identity_assign(client: AVSClient, resource_group_name, private
def privatecloud_identity_remove(client: AVSClient, resource_group_name, private_cloud):
from azext_vmware.vendored_sdks.avs_client.models import PrivateCloudIdentity, PrivateCloudUpdate
pc = PrivateCloudUpdate()
pc.identity = PrivateCloudIdentity(type=None)
pc.identity = PrivateCloudIdentity(type="None")
return client.private_clouds.begin_update(resource_group_name=resource_group_name, private_cloud_name=private_cloud, private_cloud_update=pc)


Expand Down
142 changes: 123 additions & 19 deletions src/vmware/azext_vmware/tests/latest/recordings/test_vmware.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions src/vmware/azext_vmware/tests/latest/recordings/test_vmware_addon.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading