Merged
Conversation
jonathanhe-msft
requested review from
Juliehzl and
zhoxing-ms
as code owners
cataggar
approved these changes
Nov 19, 2021
Member
cataggar
left a comment
cataggar
left a comment
There was a problem hiding this comment.
Thanks for adding the additional tests.
Contributor
Author
|
@zhoxing-ms please review. This is the final PR for the vmware 4.0.0 release. Thank you for the help! |
Collaborator
|
Vmware |
wangzelin007
approved these changes
Nov 20, 2021
zhoxing-ms
approved these changes
Nov 21, 2021
Member
|
It looks like it was not published to the index.json yet. #4136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.