Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Mar 3, 2020

Similar to #1251 [managementgroups] Remove managementgroups extension

find command is already in the main CLI.

This PR removes the whole find extension to prevent the doc from being generated and further download from customers.

@jiasli jiasli requested a review from zikalino as a code owner March 3, 2020 10:00
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jiasli/azure-cli-extensions.git@remove-find#subdirectory=src/$EXT&egg=$EXT"

@mirdaki
Copy link
Contributor

mirdaki commented Mar 3, 2020

I've added the extension suppression in this PR.

@jiasli jiasli requested a review from yungezz March 4, 2020 03:12
@jiasli jiasli self-assigned this Mar 4, 2020
@jiasli jiasli merged commit a6a34f0 into Azure:master Mar 4, 2020
@jiasli jiasli deleted the remove-find branch March 4, 2020 06:57
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants