Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Feb 6, 2020

Fix #585

management-group command group is already in the main CLI.

The doc for managementgroups is useless and self-contradictory: az account management-group create vs az managementgroups group new

This PR removes the whole managementgroups extension to prevent the doc from being generated.

@jiasli jiasli requested a review from zikalino as a code owner February 6, 2020 04:56
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jiasli/azure-cli-extensions.git@remove-managementgroups#subdirectory=src/$EXT&egg=$EXT"

@jiasli jiasli requested a review from Juliehzl February 6, 2020 04:56
@jiasli jiasli self-assigned this Feb 6, 2020
@jiasli jiasli requested a review from mmyyrroonn February 6, 2020 04:57
@yonzhan yonzhan added this to the S165 milestone Feb 6, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 6, 2020

add to S165.

@Juliehzl Juliehzl requested a review from zhoxing-ms February 6, 2020 09:40
Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoxing-ms Please take a look for the change and remove deprecate information in azure cli after the change.

@jiasli jiasli merged commit 136b57a into Azure:master Feb 7, 2020
@jiasli jiasli deleted the remove-managementgroups branch February 7, 2020 09:07
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This page is incorrect

5 participants