Skip to content

{CI} Enable CredScan task of Microsoft Security Code Analysis (Preview) #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haroldrandom merged 5 commits into from
Feb 6, 2020
Merged

{CI} Enable CredScan task of Microsoft Security Code Analysis (Preview) #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a1cb8a
Enable CredScan task of Microsoft Security Code Analysis (Preview)
Feb 6, 2020
f1f62a0
Suppress hard code dummy password in src/db-up/azext_db_up/_client_fa…
Feb 6, 2020
379f6a4
Suppress False alarm about AuthenticationType in scripts/ci/credscan/…
Feb 6, 2020
fbe261e
Suppress false alarm about AuthenticationType enum value in src/dms-p…
Feb 6, 2020
4a984b4
Suppress false alarm sign value in src/storage-preview/azext_storage_…
Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 19 additions & 26 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,32 +8,25 @@ trigger:
- '*'

jobs:
#- job: CredScan
# displayName: "Credential Scan"
#
# pool:
# vmImage: "windows-2019"
# steps:
# - task: CredScan@2
# inputs:
# toolMajorVersion: 'V2'
#
# - task: PostAnalysis@1
# inputs:
# AllTools: false
# APIScan: false
# BinSkim: false
# CodesignValidation: false
# CredScan: true
# FortifySCA: false
# FxCop: false
# ModernCop: false
# PoliCheck: false
# RoslynAnalyzers: false
# SDLNativeRules: false
# Semmle: false
# TSLint: false
# ToolLogsNotFoundAction: 'Standard'
- job: CredScan
Copy link
Member

@jsntcy jsntcy Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that CLI and extensions repo share the same yaml section instead of update twice?

displayName: "Credential Scan"
pool:
vmImage: "windows-2019"
steps:
- task: ms-codeanalysis.vss-microsoft-security-code-analysis.build-task-credscan.CredScan@2
displayName: 'CredScan'
inputs:
toolVersion: 'Latest'
suppressionsFile: './scripts/ci/credscan/CredScanSuppressions.json'
- task: ms-codeanalysis.vss-microsoft-security-code-analysis.build-task-postanalysis.PostAnalysis@1
displayName: 'Post Analysis'
inputs:
AllTools: false
BinSkim: false
CredScan: true
RoslynAnalyzers: false
TSLint: false
ToolLogsNotFoundAction: 'Standard'

- job: StaticAnalysis
displayName: "Static Analysis"
Expand Down
16 changes: 16 additions & 0 deletions CredScanSuppressions.json → ...pts/ci/credscan/CredScanSuppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,22 @@
{
"placeholder": "aduser",
"_justification": "[NetAppFiles] Add suppression for false alarm in comments of _help.py"
},
{
"placeholder": "AZURE_CLIENT_SECRET",
"_justification": "[db_up] false alarm about environment variable name"
},
{
"placeholder": "ADPassword",
"_justification": "[SQL] false alarm about AuthenticationType enum value"
},
{
"placeholder": "ActiveDirectoryPassword",
"_justification": "[DataMigration] false alarm about AuthenticationType enum value"
},
{
"placeholder": "Ovg+o0K/0/2V8upg7AwlyAPCriEcOSXKuBu2Gv/PU70Y7aWDW3C2ZRmw6kYWqPWBaM1GosLkcSZkgsobAlT+Sw==",
"_justification": "[ADLS] false alarm on sign value"
}
]
}