Skip to content

Conversation

@haroldrandom
Copy link
Contributor

The same as Azure/azure-cli#12019


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@haroldrandom haroldrandom self-assigned this Feb 6, 2020
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@reenable-credscan#subdirectory=src/$EXT&egg=$EXT"

Jianhui Harold added 4 commits February 6, 2020 13:42
…review/azext_dms/vendored_sdks/datamigration/models/_data_migration_service_client_enums.py
…preview/vendored_sdks/azure_adls_storage_preview/v2019_02_02_preview/blob/_deserialization.py
@haroldrandom haroldrandom marked this pull request as ready for review February 6, 2020 06:12
# Semmle: false
# TSLint: false
# ToolLogsNotFoundAction: 'Standard'
- job: CredScan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that CLI and extensions repo share the same yaml section instead of update twice?

@haroldrandom
Copy link
Contributor Author

haroldrandom commented Feb 6, 2020 via email

@yonzhan yonzhan added this to the S165 milestone Feb 6, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 6, 2020

add to S165.

@haroldrandom haroldrandom merged commit 76de2f6 into Azure:master Feb 6, 2020
@haroldrandom haroldrandom deleted the reenable-credscan branch February 6, 2020 08:23
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants