Skip to content

remove all hosts from global parameters #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 3 commits into from
Jul 13, 2021
Merged

remove all hosts from global parameters #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd59800
remove all hosts from global parameters
iscai-msft Jul 13, 2021
379c40a
update changelog and package.json
iscai-msft Jul 13, 2021
11a4308
improve code look
iscai-msft Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Change Log

### 2021-07-06 - 5.8.4

min Autorest core version: 3.3.0

min Modelerfour version: 4.19.1

**Bug Fixes**

- Remove all hosts from global parameters, regardless of how many m4 sends us #972

### 2021-07-06 - 5.8.3

min Autorest core version: 3.3.0
Expand Down
6 changes: 3 additions & 3 deletions autorest/codegen/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ def _create_code_model(self, yaml_data: Dict[str, Any], options: Dict[str, Union
first_req_of_first_op_of_first_grp = yaml_data["operationGroups"][0]["operations"][0]["requests"][0]
code_model.custom_base_url = first_req_of_first_op_of_first_grp["protocol"]["http"]["uri"]
else:
dollar_host_parameter = dollar_host[0]
code_model.global_parameters.remove(dollar_host_parameter)
code_model.base_url = dollar_host_parameter.yaml_data["clientDefaultValue"]
for host in dollar_host:
code_model.global_parameters.remove(host)
code_model.base_url = dollar_host[0].yaml_data["clientDefaultValue"]

# Create operations
if yaml_data.get("operationGroups"):
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@autorest/python",
"version": "5.8.3",
"version": "5.8.4",
"description": "The Python extension for generators in AutoRest.",
"scripts": {
"prepare": "node run-python3.js prepare.py",
Expand Down