remove all hosts from global parameters #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmazuel
reviewed
Jul 13, 2021
autorest/codegen/__init__.py
Outdated
| code_model.global_parameters.remove(dollar_host_parameter) | ||
| code_model.base_url = dollar_host_parameter.yaml_data["clientDefaultValue"] | ||
| code_model.global_parameters.parameters = [ | ||
| p for p in code_model.global_parameters.parameters if p.rest_api_name != "$host" |
Member
There was a problem hiding this comment.
dollar_host is already the list of thing you want to remove, so you can do
for host in dollar_host:
code_model.global_parameters.remove(host)
iscai-msft
added a commit
that referenced
this pull request
Jul 13, 2021
…into reserved_parameter_grouping * 'autorestv3' of https://github.com/Azure/autorest.python: remove all hosts from global parameters (#972) Disable LLC and M4 conflicts (#969)
iscai-msft
added a commit
that referenced
this pull request
Jul 14, 2021
…into prepare_request * 'autorestv3' of https://github.com/Azure/autorest.python: fix case of grouped parameter + reserved property name (#970) remove all hosts from global parameters (#972)
iscai-msft
added a commit
that referenced
this pull request
Jul 15, 2021
…ython into hybrid * 'prepare_request' of https://github.com/Azure/autorest.python: add llc param grouping with reserved word test pad private variables for LLC fix case of grouped parameter + reserved property name (#970) remove all hosts from global parameters (#972) fix relative path to testserver in vanilla conftests add conftest in each acceptance tests folder vanilla llc pylint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.